Skip to content

Add overflow checks to getLeadingDims and getTrailingDims #19270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rascani wants to merge 2 commits into
base: main
Choose a base branch
from
+15 −2
Open

Add overflow checks to getLeadingDims and getTrailingDims #19270

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e611bbc
Add overflow checks to getLeadingDims and getTrailingDims
rascani May 1, 2026
34ef14d
Fix formatting
rascani May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions runtime/core/exec_aten/util/tensor_util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
#pragma once

#include <c10/util/irange.h>
#include <c10/util/safe_numerics.h>
#include <algorithm>
#include <array> // std::array
#include <cinttypes> // PRId64
Expand Down Expand Up @@ -932,7 +933,13 @@ inline size_t getLeadingDims(
ssize_t(tensor.dim()));
size_t dims = 1;
for (const auto i : c10::irange(dim)) {
dims *= static_cast<size_t>(tensor.size(i));
size_t next_dims;
ET_CHECK_MSG(
!c10::mul_overflows(
dims, static_cast<size_t>(tensor.size(i)), &next_dims),
"Overflow computing leading dims at dimension %zd",
(ssize_t)i);
dims = next_dims;
}
return dims;
}
Expand All @@ -949,7 +956,13 @@ inline size_t getTrailingDims(
ssize_t(tensor.dim()));
size_t dims = 1;
for (size_t i = dim + 1; i < static_cast<size_t>(tensor.dim()); ++i) {
dims *= static_cast<size_t>(tensor.size(i));
size_t next_dims;
ET_CHECK_MSG(
!c10::mul_overflows(
dims, static_cast<size_t>(tensor.size(i)), &next_dims),
"Overflow computing trailing dims at dimension %zu",
i);
dims = next_dims;
}
return dims;
}
Expand Down
Loading