Skip to content

Add null checks in tensor parser to prevent SIGSEGV#19267

Open
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:export-D103467786
Open

Add null checks in tensor parser to prevent SIGSEGV#19267
rascani wants to merge 1 commit intopytorch:mainfrom
rascani:export-D103467786

Conversation

@rascani
Copy link
Copy Markdown
Contributor

@rascani rascani commented May 1, 2026

Summary:
Add two defensive checks in tensor_parser_exec_aten.cpp:

  1. getMemPlannedPtr(): Validate that the HierarchicalAllocator pointer is non-null before dereferencing it. A null allocator causes a SIGSEGV when a model has memory-planned tensors but the caller provides zero planned buffers (T266226256 — wearables Android crash at 0.0003% hit rate).

  2. getTensorDataPtr(): When a tensor has allocation_info (indicating it expects memory-planned storage), validate that the allocator is non-null before any code path reaches getMemPlannedPtr(). This is the primary fix; the check in getMemPlannedPtr is defense-in-depth.

Differential Revision: D103467786

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 1, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19267

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Unrelated Failures

As of commit f0fa552 with merge base a3dd0fa (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 1, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 1, 2026

@rascani has exported this pull request. If you are a Meta employee, you can view the originating Diff in D103467786.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Summary:
Add two defensive checks in `tensor_parser_exec_aten.cpp`:

1. `getMemPlannedPtr()`: Validate that the `HierarchicalAllocator` pointer is non-null before dereferencing it. A null allocator causes a SIGSEGV when a model has memory-planned tensors but the caller provides zero planned buffers (T266226256 — wearables Android crash at 0.0003% hit rate).

2. `getTensorDataPtr()`: When a tensor has `allocation_info` (indicating it expects memory-planned storage), validate that the allocator is non-null before any code path reaches `getMemPlannedPtr()`. This is the primary fix; the check in `getMemPlannedPtr` is defense-in-depth.

Differential Revision: D103467786
@rascani rascani force-pushed the export-D103467786 branch from 6b96a40 to f0fa552 Compare May 1, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant