gh-148925: Add PyUnstable_CollectCallStack and PyUnstable_PrintCallStack#148930
Open
danielsn wants to merge 1 commit intopython:mainfrom
Open
gh-148925: Add PyUnstable_CollectCallStack and PyUnstable_PrintCallStack#148930danielsn wants to merge 1 commit intopython:mainfrom
danielsn wants to merge 1 commit intopython:mainfrom
Conversation
danielsn
requested review from
a team,
AA-Turner,
ZeroIntensity,
emmatyping and
erlend-aasland
as code owners
|
All commit authors signed the Contributor License Agreement. |
danielsn
commented
Apr 23, 2026
|
|
||
| /* Buffer size for the filename and name fields in PyUnstable_FrameInfo: | ||
| up to 500 content bytes plus '\0' (1). */ | ||
| #define Py_UNSTABLE_FRAMEINFO_STRSIZE 501 |
Author
There was a problem hiding this comment.
I used 500 because that was what the print to fd version used, https://github.com/danielsn/cpython/blob/main/Python/traceback.c#L56C9-L56C26 but this seems larger than we'd need in practice.
danielsn
commented
Apr 23, 2026
| the respective string was longer than Py_UNSTABLE_FRAMEINFO_STRSIZE-1 | ||
| bytes and was truncated. */ | ||
| typedef struct { | ||
| int lineno; |
Author
There was a problem hiding this comment.
The code object has other fields (e.g. column), would these be worth collecting as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#145559 proposes a signal-safe mechanism to print backtraces. This is useful for human debugging, but not ideal for tools because it requires parsing human-readable text. For example, a crash-tracker may wish to export and analyze structured backtraces. Similarly, a profiler can benefit from the ability to generate structure stack-traces in pure C, without needing to reason about the safety of reentering the python interpreter.
📚 Documentation preview 📚: https://cpython-previews--148930.org.readthedocs.build/