Skip to content

gh-148801: Fix unbound C recursion in Element.__deepcopy__()#148802

Merged
StanFromIreland merged 3 commits intopython:mainfrom
StanFromIreland:Element.__deepcopy__
Apr 21, 2026
Merged

gh-148801: Fix unbound C recursion in Element.__deepcopy__()#148802
StanFromIreland merged 3 commits intopython:mainfrom
StanFromIreland:Element.__deepcopy__

Conversation

@StanFromIreland
Copy link
Copy Markdown
Member

@StanFromIreland StanFromIreland commented Apr 20, 2026

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

I have a style suggestion which you can accept or ignore.

Comment thread Modules/_elementtree.c Outdated
@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Apr 21, 2026
@StanFromIreland StanFromIreland merged commit 33e82be into python:main Apr 21, 2026
58 checks passed
@miss-islington-app
Copy link
Copy Markdown

Thanks @StanFromIreland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app
Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33e82be1746a964b595b2bba64f38a5787681eb3 3.14

@StanFromIreland StanFromIreland deleted the Element.__deepcopy__ branch April 21, 2026 16:20
@miss-islington-app
Copy link
Copy Markdown

Sorry, @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 33e82be1746a964b595b2bba64f38a5787681eb3 3.13

@StanFromIreland
Copy link
Copy Markdown
Member Author

Thanks for the review @serhiy-storchaka !

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 21, 2026

GH-148842 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Apr 21, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 21, 2026

GH-148843 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants