Skip to content

Improve clarity of enum comparison sentence#148753

Merged
ethanfurman merged 2 commits intopython:mainfrom
ZougaRida:ZougaRida-modify-docs
Apr 21, 2026
Merged

Improve clarity of enum comparison sentence#148753
ethanfurman merged 2 commits intopython:mainfrom
ZougaRida:ZougaRida-modify-docs

Conversation

@ZougaRida
Copy link
Copy Markdown
Contributor

@ZougaRida ZougaRida commented Apr 19, 2026 •
edited by github-actions Bot
Loading

@ZougaRida ZougaRida requested a review from ethanfurman as a code owner April 19, 2026 12:15
@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented Apr 19, 2026 •
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Apr 19, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Apr 19, 2026
ethanfurman
ethanfurman requested changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ethanfurman ethanfurman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change and then it looks good.

Comment thread Doc/howto/enum.rst Outdated
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 21, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be poked with soft cushions!

@ZougaRida @ethanfurman
Make additional change to the enum sentence to improve clarity
de5ef54 
Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
@ZougaRida
Copy link
Copy Markdown
Contributor Author

ZougaRida commented Apr 21, 2026

I have made the requested changes; please review again

@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 21, 2026

Thanks for making the requested changes!

@ethanfurman: please review the changes made to this pull request.

@bedevere-app bedevere-app Bot requested a review from ethanfurman April 21, 2026 11:02
@ethanfurman ethanfurman merged commit 0b9146e into python:main Apr 21, 2026
35 of 38 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Apr 21, 2026
@ethanfurman
Copy link
Copy Markdown
Member

ethanfurman commented Apr 21, 2026

Thanks, @ZougaRida !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman approved these changes

@picnixz picnixz picnixz approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZougaRida @ethanfurman @picnixz