Skip to content

Fix test_snippets_completion to not depend on typeshed overload ordering #709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
frenzymadness wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix test_snippets_completion to not depend on typeshed overload ordering #709

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/plugins/test_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ def test_matplotlib_completions(config, workspace) -> None:


def test_snippets_completion(config, workspace) -> None:
doc_snippets = "from collections import defaultdict \na=defaultdict"
doc_snippets = "from collections import defaultdict \ndef foo(a): pass\nfoo"
com_position = {"line": 0, "character": 35}
doc = Document(DOC_URI, workspace, doc_snippets)
config.capabilities["textDocument"] = {
Expand All @@ -332,9 +332,9 @@ def test_snippets_completion(config, workspace) -> None:
completions = pylsp_jedi_completions(config, doc, com_position)
assert completions[0]["insertText"] == "defaultdict"

com_position = {"line": 1, "character": len(doc_snippets)}
com_position = {"line": 2, "character": 3}
completions = pylsp_jedi_completions(config, doc, com_position)
assert completions[0]["insertText"] == "defaultdict($0)"
assert completions[0]["insertText"] == "foo($0)"
assert completions[0]["insertTextFormat"] == lsp.InsertTextFormat.Snippet


Expand Down