Skip to content

Fix the lint failures that are failing CI on main (ruff + clippy) #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HarperZ9 wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −10
Open

Fix the lint failures that are failing CI on main (ruff + clippy) #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36fa166
Fix ruff FURB110 lint failure in test filesystem adaptor
Jun 30, 2026
ab39a71
Fix clippy collapsible_match in import_parsing (Rust lint step)
Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions rust/src/import_parsing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,14 +127,10 @@ impl<'a> StatementVisitor<'a> for Visitor<'a> {
walk_stmt(self, stmt);
}
}
Expr::Attribute(expr) => {
if expr.attr.id == "TYPE_CHECKING" {
self.typechecking_only = true;
walk_stmt(self, stmt);
self.typechecking_only = false;
} else {
walk_stmt(self, stmt);
}
Expr::Attribute(expr) if expr.attr.id == "TYPE_CHECKING" => {
self.typechecking_only = true;
walk_stmt(self, stmt);
self.typechecking_only = false;
}
_ => {
walk_stmt(self, stmt);
Expand Down
4 changes: 2 additions & 2 deletions tests/adaptors/filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,8 @@ def __init__(
"""
self.contents = self._parse_contents(contents)
self._raw_contents = contents
self.content_map = content_map if content_map else {}
self.mtime_map: dict[str, float] = mtime_map if mtime_map else {}
self.content_map = content_map or {}
self.mtime_map: dict[str, float] = mtime_map or {}

@property
def sep(self) -> str:
Expand Down
Loading