Open
Conversation
Remove the dim==1 guard in Triangulation and add 1D initialization that sorts points and creates interval simplices. Fix simplex_volume_in_embedding for line segments, add interp1d-based interpolation for 1D LearnerND, and add 1D plot support. Also fix DataSaver's _to_key to handle LearnerND's tuple keys for 1D points, and fix positional indexing in load_dataframe (iloc). Includes comprehensive tests: 8 dedicated 1D triangulation tests, 6 unit LearnerND tests, 4 integration tests, dim=1 added to 8 existing parametrized tests, and a 1D function registered for cross-learner tests.
1. Fix 1D plot() crash: flatten ((x,), y) tuples to (x, y) for np.array compatibility in Scatter data. 2. Fix 1D _ip() for vector outputs: pass axis=0 to interp1d so R^1 -> R^M functions interpolate correctly. 3. Fix duplicate 1D coordinates: skip adjacent duplicates after sorting to avoid degenerate zero-volume simplices. 4. Fix flaky test_circumsphere for dim=1: special-case dim==1 to generate center ± radius deterministically instead of Gaussian sampling that can place both points on the same side. Adds regression tests for all four issues.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes ISSUE-095