Fix Minimize Ops type strictness#2279
Open
ricardoV94 wants to merge 2 commits into
Open
Conversation
In Composite, only try to rebuild graph if types are not "filter"-compatible
ricardoV94
force-pushed
the
less_strict_minimize
branch
from
5263c14 to
d744ddd
Compare
ricardoV94
force-pushed
the
less_strict_minimize
branch
from
d744ddd to
edfb52e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two issues we found on the pymc-extras CI.
This is actually present in jaxified_graph helper in PyMC, because Mode(...).optimizer did not propagate the _compile_mode to the fgraph so the inner graph rewriters can see it. Moved it one level down which covers both paths.