Deduplicate system test entries in tests.yaml#775
Open
PranjalManhgaye wants to merge 1 commit into
Open
Conversation
Use YAML anchors and aliases for repeated tutorial entries to keep the system test configuration easier to maintain without changing the resolved test suites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #767 by reducing duplication in " tools/tests/tests.yaml" , We use YAML anchors and aliases for tutorial entries that appear in multiple test suites. The resolved test configuration stays the same, but the file becomes shorter and easier to maintain when we need to update shared tutorial entries later.
What changed
Why
Before this change, we had the same tutorial entries repeated in several suites. If we wanted to update one shared entry later, we would have to remember to update every copy. With this change, we define the repeated entries once and reuse them where needed. This should make future maintenance simpler without changing how the system tests behave.
Validation
I checked that this only changes the YAML structure, not the resolved test configuration.
Ran locally:
bash
git diff --check python3 -m compileall tools/tests python3 tools/tests/systemtests.py --helpI also compared the parsed
tests.yamlagainstupstream/develop; both resolved to the same13test suites and37tutorial entries.Checklist:
changelog-entries/<PRnumber>.md.