Improvements - multi-select and some performance optimizations

.github/workflows/build-pr.yml

@@ -39,4 +39,11 @@ jobs:
       - name: Restore & build the application
         run: dotnet build $env:Solution_Name --configuration $env:Configuration
         env:
-          Configuration: ${{ matrix.configuration }}
+          Configuration: ${{ matrix.configuration }}
+
+      - name: Upload build artifacts
+        uses: actions/upload-artifact@v7.0.0
+        with:
+          name: UOFiddler-PR${{ github.event.pull_request.number }}-${{ github.sha }}
+          path: ./UoFiddler/bin/Release/
+          retention-days: 7

Ultima/AnimationEdit.cs

@@ -12,12 +12,14 @@ public sealed class AnimationEdit
         private static FileIndex _fileIndex3 = new FileIndex("Anim3.idx", "Anim3.mul", -1);
         private static FileIndex _fileIndex4 = new FileIndex("Anim4.idx", "Anim4.mul", -1);
         private static FileIndex _fileIndex5 = new FileIndex("Anim5.idx", "Anim5.mul", -1);
+        private static FileIndex _fileIndex6 = new FileIndex("Anim6.idx", "Anim6.mul", -1);
 
         private static AnimIdx[] _animCache;
         private static AnimIdx[] _animCache2;
         private static AnimIdx[] _animCache3;
         private static AnimIdx[] _animCache4;
         private static AnimIdx[] _animCache5;
+        private static AnimIdx[] _animCache6;
 
         static AnimationEdit()
         {
@@ -50,6 +52,11 @@ private static void InitializeCache()
             {
                 _animCache5 = new AnimIdx[_fileIndex5.IdxLength / 12];
             }
+
+            if (_fileIndex6.IdxLength > 0)
+            {
+                _animCache6 = new AnimIdx[_fileIndex6.IdxLength / 12];
+            }
         }
 
         /// <summary>
@@ -62,6 +69,7 @@ public static void Reload()
             _fileIndex3 = new FileIndex("Anim3.idx", "Anim3.mul", -1);
             _fileIndex4 = new FileIndex("Anim4.idx", "Anim4.mul", -1);
             _fileIndex5 = new FileIndex("Anim5.idx", "Anim5.mul", -1);
+            _fileIndex6 = new FileIndex("Anim6.idx", "Anim6.mul", -1);
 
             InitializeCache();
         }
@@ -147,6 +155,22 @@ private static void GetFileIndex(
                         index = 35000 + ((body - 400) * 175);
                     }
 
+                    break;
+                case 6:
+                    fileIndex = _fileIndex6;
+                    if (body < 200)
+                    {
+                        index = body * 110;
+                    }
+                    else if (body < 400)
+                    {
+                        index = 22000 + ((body - 200) * 65);
+                    }
+                    else
+                    {
+                        index = 35000 + ((body - 400) * 175);
+                    }
+
                     break;
             }
 
@@ -176,6 +200,8 @@ private static AnimIdx[] GetCache(int fileType)
                     return _animCache4;
                 case 5:
                     return _animCache5;
+                case 6:
+                    return _animCache6;
                 default:
                     return _animCache;
             }
@@ -197,6 +223,16 @@ public static AnimIdx GetAnimation(int fileType, int body, int action, int dir)
 
         public static bool IsActionDefined(int fileType, int body, int action)
         {
+            // Reject actions beyond the body's physical idx block before computing
+            // the index; otherwise index = base + action*5 crosses into the next
+            // body's records. Replaces a prior off-by-one GetAnimLength check
+            // (animCount < action) that both missed the boundary and used the
+            // now-clamped category count.
+            if (action < 0 || action >= Animations.GetActionCapacity(body, fileType))
+            {
+                return false;
+            }
+
             AnimIdx[] cache = GetCache(fileType);
 
             GetFileIndex(body, fileType, action, 0, out FileIndex fileIndex, out int index);
@@ -206,12 +242,6 @@ public static bool IsActionDefined(int fileType, int body, int action)
                 return cache[index].Frames?.Count > 0;
             }
 
-            int animCount = Animations.GetAnimLength(body, fileType);
-            if (animCount < action)
-            {
-                return false;
-            }
-
             bool valid = fileIndex.Valid(index, out int length, out int _, out bool _);
 
             return valid && length >= 1;
@@ -316,6 +346,11 @@ public static void Save(int fileType, string path)
                     cache = _animCache5;
                     fileIndex = _fileIndex5;
                     break;
+                case 6:
+                    filename = "anim6";
+                    cache = _animCache6;
+                    fileIndex = _fileIndex6;
+                    break;
             }
 
             string idx = Path.Combine(path, filename + ".idx");
@@ -374,7 +409,10 @@ public AnimIdx(int index, FileIndex fileIndex)
 
             _idxExtra = extra;
 
-            using (var bin = new BinaryReader(stream))
+            // leaveOpen: stream is owned by the shared FileIndex; disposing the
+            // BinaryReader must not close it, or the next FileIndex.Seek pays a
+            // full re-open.
+            using (var bin = new BinaryReader(stream, System.Text.Encoding.UTF8, leaveOpen: true))
             {
                 for (int i = 0; i < PaletteCapacity; ++i)
                 {
@@ -399,8 +437,6 @@ public AnimIdx(int index, FileIndex fileIndex)
                     Frames.Add(new FrameEdit(bin));
                 }
             }
-
-            stream.Close();
         }
 
         public AnimIdx(BinaryReader bin, int extra)