Skip to content

tidb-cloud: update metrics to add row-based standard storage#23046

Merged
ti-chi-bot[bot] merged 4 commits into
pingcap:release-8.5from
lilin90:update-metrics
Jun 11, 2026
Merged

tidb-cloud: update metrics to add row-based standard storage#23046
ti-chi-bot[bot] merged 4 commits into
pingcap:release-8.5from
lilin90:update-metrics

Conversation

@lilin90

@lilin90 lilin90 commented Jun 11, 2026

Copy link
Copy Markdown
Member

What is changed, added or deleted? (Required)

Updated metrics to add Row-based standard storage for Starter and Essential, as requested by @zhaoshangzi

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@lilin90 lilin90 self-assigned this Jun 11, 2026
@lilin90 lilin90 added area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. labels Jun 11, 2026
@ti-chi-bot ti-chi-bot Bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 11, 2026
@lilin90 lilin90 added the translation/no-need No need to translate this PR. label Jun 11, 2026
@ti-chi-bot ti-chi-bot Bot removed the missing-translation-status This PR does not have translation status info. label Jun 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the built-in-monitoring.md documentation to include 'Row-based standard storage' in the 'Used Storage Size' metric description. The review feedback suggests bolding the UI labels 'Row-based standard storage' and 'Row-based storage' within the description to maintain formatting consistency with the rest of the document.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tidb-cloud/built-in-monitoring.md Outdated
@ti-chi-bot ti-chi-bot Bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jun 11, 2026
@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-06-11 10:45:59.186131228 +0000 UTC m=+1043260.256448618: ☑️ agreed by qiancai.

@lilin90 lilin90 added the lgtm label Jun 11, 2026
@lilin90

lilin90 commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

/approve

@ti-chi-bot

ti-chi-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lilin90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Jun 11, 2026
@ti-chi-bot ti-chi-bot Bot merged commit 142a948 into pingcap:release-8.5 Jun 11, 2026
11 checks passed
@lilin90 lilin90 deleted the update-metrics branch June 11, 2026 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants