Refactor pc config to support key-based configuration and commands#90
Open
austin-denoble wants to merge 2 commits into
Open
Refactor pc config to support key-based configuration and commands#90austin-denoble wants to merge 2 commits into
pc config to support key-based configuration and commands#90austin-denoble wants to merge 2 commits into
Conversation
…mands Replaces the per-setting subcommands (get-api-key, set-api-key, set-color, set-environment) with a generic, registry-driven interface modeled after `gh config` and `aws configure`. A new keyDescriptor in registry.go holds each setting's getter, setter, validator, side-effect hook, short/long descriptions, and sensitivity flag. Adding a new key is supported through a registry entry rather than a command file. Adds `pc config get|set|unset|list|describe <key>`, with --json and --reveal flag support for sensitive values like API keys. The four legacy commands are maintained as hidden, deprecated aliases to maintain functionality for existing users.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0af76ca. Configure here.
`pc config unset` now invokes the onChange hook when clearing a key changes its value, fixing a bug where `unset environment` on staging silently resets to production without clearing the staging-tied OAuth session, API key, or target org/project. `pc config set` now passes the canonical stored value to onChange via a post-set getStr() read, rather than the raw user input. Hooks like environment's now see "production" instead of "prod" when the input is normalized during setStr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
The
pc configcommand exposed configuration through a flat set of verb-noun subcommands —get-api-key,set-api-key,set-color,set-environment— with one Cobra command file per setting. The pattern had a few problems:listequivalent.gh,aws,npm,stripe) handle config, raising the learning curve for new users.This becomes more painful as the set of configurable values grows.
Solution
Refactor
pc configto a generic, registry-driven interface modeled aftergh config. A singlekeyDescriptorininternal/pkg/cli/command/config/registry.goholds each setting's getter, setter, clear function, optionalonChangeside-effect hook, short and long descriptions, sensitivity flag, and valid values. Theget/set/unset/list/describecommands are generic and dispatch through the registry — adding a new config key is now a single registry entry, no new command file required.New commands
Registry-driven extensibility
Each setting is one entry in
configRegistry. Adding a new key — say, a default output format — would look like:No new command file. No changes to
root.go's skip-auth list. It just works acrossget,set,unset,list, anddescribe.Side-effect hooks
The
environmentkey needs to clear OAuth state, the API key, and the target org/project when it changes. That used to live inline inset-environment. It now lives in anonChangehook on the registry entry and fires consistently from bothsetandunset:Flags
--jsononget,list,describefor machine-readable output.--revealonget,list,describeto unmask sensitive values (defaults to masking head/tail forapi-key).Backwards compatibility
The four legacy commands (
get-api-key,set-api-key,set-color,set-environment) are preserved as hidden, deprecated aliases. They continue to function and print Cobra's standard deprecation noticepointing at the new equivalent:
Existing scripts and docs keep working; new users land on the new pattern.
Type of Change
The legacy commands are kept as hidden aliases, so this is non-breaking for existing users. Docs referencing
pc config set-api-keyetc. should be updated to usepc config set api-key <value>going forward.Test Plan
just test-unitpassespc config list— confirms all three keys render with descriptionspc config get api-key— confirms<not set>placeholder for empty valuespc config get api-key --reveal— confirms full value shown when revealedpc config set environment staging— confirms OAuth/API key/target wipe firespc config unset environment(from staging) — confirms same wipe fires (regression fix)pc config set environment prod— confirms canonical "production" is stored and reportedpc config describe api-key/environment/color— confirms long description rendered when present, omitted when blankpc config get-api-key/set-api-key/set-color/set-environment— confirms each still works and prints deprecation notice--jsononget,list,describe— confirms structured output