Skip to content

[diffs] Fix for theme changes on collapsed files#733

Merged
amadeus merged 2 commits into
mainfrom
amadeus/fix-theme-changes
May 22, 2026
Merged

[diffs] Fix for theme changes on collapsed files#733
amadeus merged 2 commits into
mainfrom
amadeus/fix-theme-changes

Conversation

@amadeus
Copy link
Copy Markdown
Member

@amadeus amadeus commented May 22, 2026

Some of my render optimizations actually didn't make sense, and caused some funky side effects when changing themes, especially with collapsed files.

Also, found found some issues where we would aggressively attempt to render highlight plain text files when we probably shouldn't.

@vercel
Copy link
Copy Markdown

vercel Bot commented May 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
pierre-docs-diffshub Ready Ready Preview May 22, 2026 12:56am
pierre-docs-trees Ready Ready Preview May 22, 2026 12:56am
pierrejs-diff-demo Ready Ready Preview May 22, 2026 12:56am
pierrejs-docs Ready Ready Preview May 22, 2026 12:56am

Request Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0d4731a6e3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diffs/src/renderers/FileRenderer.ts Outdated
Comment thread packages/diffs/src/renderers/DiffHunksRenderer.ts Outdated
Comment thread packages/diffs/src/renderers/DiffHunksRenderer.ts Outdated
Comment thread packages/diffs/src/renderers/FileRenderer.ts Outdated
Comment thread packages/diffs/src/renderers/DiffHunksRenderer.ts Outdated
@amadeus
Copy link
Copy Markdown
Member Author

amadeus commented May 22, 2026

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 14a42a9c62

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diffs/src/renderers/FileRenderer.ts
Comment thread packages/diffs/src/renderers/DiffHunksRenderer.ts
@amadeus amadeus merged commit 1edbbc9 into main May 22, 2026
12 checks passed
@amadeus amadeus deleted the amadeus/fix-theme-changes branch May 22, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants