ext/phar: Avoid repeated strlen() calls in phar_fancy_stat()#21865
Open
LamentXU123 wants to merge 1 commit intophp:masterfrom
Open
ext/phar: Avoid repeated strlen() calls in phar_fancy_stat()#21865LamentXU123 wants to merge 1 commit intophp:masterfrom
LamentXU123 wants to merge 1 commit intophp:masterfrom
Conversation
Member
|
I would say yes even though the benefit is really more the readability improvement more than "saving strlen calls", nowadays strlen(str)/sizeof(str)-1 the former still use __builtin_strlen behind the scene with compile time strings like here. |
Contributor
Author
|
Test failures are unrelated :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch removes the temporary key array and uses
ZEND_STRL(...)directly for each fixed key instead. This avoid repeated strlen() calls and also reduce code complexity.