feat(helm): support user-provided API key env#315
Open
omribz156 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
pdp.userProvidedSecretto let chart users skip creating the chart-managed API key Secret.PDP_API_KEYsecretKeyRefwhen that option is enabled, so users can injectPDP_API_KEYthroughpdpEnvsor another mechanism.existingApiKeySecretbehavior unchanged and bump the chart patch version.Verification:
helm lint charts/pdphelm template pdp charts/pdphelm template pdp charts/pdp -f <userProvidedSecret values>rendered no Secret, nosecretKeyRef, and included the user-providedPDP_API_KEYenv.helm template pdp charts/pdp -f <existingApiKeySecret values>still rendered no Secret and kept the externalsecretKeyRef.This was implemented with Codex assistance, with the patch kept focused and manually reviewed.
Closes #300