Skip to content

Preserve repeated facts query params#314

Open
omribz156 wants to merge 1 commit into
permitio:mainfrom
omribz156:codex/preserve-forwarded-query-values
Open

Preserve repeated facts query params#314
omribz156 wants to merge 1 commit into
permitio:mainfrom
omribz156:codex/preserve-forwarded-query-values

Conversation

@omribz156
Copy link
Copy Markdown

Summary

  • preserve repeated query parameters when forwarding facts requests to the control plane
  • keep explicit forwarded query overrides replacing existing values
  • add focused coverage for repeated params and override behavior

Fixes #299.

Verification

  • .venv\Scripts\python -m pytest horizon\tests\test_facts_client.py
  • .venv\Scripts\python -m pytest horizon\tests\test_facts_client.py horizon\tests\test_facts_router.py
  • .venv\Scripts\python -m ruff check horizon\facts\client.py horizon\tests\test_facts_client.py
  • git diff --check

Implemented with Codex assistance, with the patch kept focused and manually reviewed before opening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forwarded user role assignments GET request has user filter array collapsed to single value

1 participant