Skip to content

Build secp256k1 via cmake ExternalProject, no pre-built DLL required.#42

Open
danrmiller wants to merge 1 commit into
peercoin:masterfrom
cypherstack:fix/windows-cmake-externalproject
Open

Build secp256k1 via cmake ExternalProject, no pre-built DLL required.#42
danrmiller wants to merge 1 commit into
peercoin:masterfrom
cypherstack:fix/windows-cmake-externalproject

Conversation

@danrmiller

Copy link
Copy Markdown

Resolves the TODO in windows/CMakeLists.txt, so re-enables add_subdirectory in src/CMakeLists.txt so secp256k1 is built via cmake ExternalProject during flutter build windows, the same way it works on Linux and Android. No pre-built DLL required.

Tested on windows-latest (Windows Server 2025, VS 2026): https://github.com/cypherstack/coinlib/actions/runs/26660965448/job/78583115194

@danrmiller danrmiller closed this May 30, 2026
@danrmiller danrmiller reopened this May 30, 2026
@peerchemist
peerchemist requested a review from MatthewLM May 30, 2026 09:08
@MatthewLM

Copy link
Copy Markdown
Collaborator

Thank you @danrmiller. Sorry for the delay in getting to this.

secp256k1 builds are now moving to use https://github.com/peercoin/secp256k1-coinlib in branch v5.0.0.

Would you be willing to get this to work for v5.0.0 and verify that the coinlib/bin build scripts for windows also work?

Otherwise Windows support will be dropped for v5.0.0 unless someone else can test.

@sneurlax

Copy link
Copy Markdown
Contributor

Thank you @danrmiller. Sorry for the delay in getting to this.

secp256k1 builds are now moving to use https://github.com/peercoin/secp256k1-coinlib in branch v5.0.0.

Would you be willing to get this to work for v5.0.0 and verify that the coinlib/bin build scripts for windows also work?

Otherwise Windows support will be dropped for v5.0.0 unless someone else can test.

Hey @MatthewLM, I will check this tomorrow. I only just saw it or else I'd have done it earlier. Been working on Windows today, guess I will be tomorrow as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants