expand zerocopy IntoBytes/FromByes use in guest memory accesses#1130
Merged
expand zerocopy IntoBytes/FromByes use in guest memory accesses#1130
Conversation
Forever ago (oct 2024) when I'd added FromBytes bounds for reads from guest memory in ff0b76d, I'd overlooked virtio queues and that the constraint is interesting on the write path too.
iximeow
force-pushed
the
ixi/zerocopy-zeropaste
branch
from
f2f2f8f to
b39adc8
Compare
FelixMcFelix
approved these changes
Apr 29, 2026
Contributor
FelixMcFelix
left a comment
FelixMcFelix
left a comment
There was a problem hiding this comment.
Looks good, thanks for doing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forever ago (oct 2024) when I'd added FromBytes bounds for reads from guest memory in ff0b76d, I'd overlooked virtio queues and that the constraint is interesting on the write path too.
does the things @FelixMcFelix very rightfully suggested in #1126.