chore(deps): bump @ownclouders/* web packages from 12.3.2 to 12.4.1#479
Merged
Merged
Conversation
web-client 12.4.x makes Resource.spaceId required (it was optional before). That breaks the repo-wide check:types in two spots, fixed here: - web-app-advanced-search: SearchResource re-declared spaceId as optional, which illegally widens the now-required base property (TS2430) and left SearchResource unassignable to Resource (TS2322). spaceId is always set in parseSearchResponse, so it is now declared required. - web-app-ai-image-alt-text-sidebar: a unit-test Resource fixture omitted the now-required spaceId; added it. Verified on 12.4.1: pnpm check:types, pnpm lint (0 errors), and the full pnpm test:unit suite are green across the workspace. Supersedes the @ownclouders portion of owncloud#471. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: David Walter <david.walter@kiteworks.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
LukasHirt
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
@ownclouders/web-client12.4.x makesResource.spaceIdrequired (it was optional in 12.3.x). Bumping the@ownclouders/*web packages to 12.4.1 — as dependabot proposes in #471 — therefore fails the repo-widecheck:typesjob, which blocks the entire bump. (Same failure that surfaced on #460 once its lockfile briefly drifted to 12.4.1.)Changes
@ownclouders/web-client,web-pkg,extension-sdk,web-test-helpers, andeslint-configfrom^12.3.2→^12.4.1across the workspace, with a regeneratedpnpm-lock.yaml.src/types/index.ts):SearchResourcere-declaredspaceIdas optional, which illegally widens the now-required base property (TS2430) and leftSearchResourceunassignable toResource(TS2322). It is always populated inparseSearchResponse, so it is now declared required.tests/unit/AltTextPanel.spec.ts): one unit-testResourcefixture omitted the now-requiredspaceId; added it.Testing
All green across the workspace on 12.4.1:
pnpm check:typespnpm lint(0 errors)pnpm test:unitRelation to #471
This carries the
@owncloudersportion of dependabot #471 plus the two source fixes that bump needs to compile (they can't ship separately — the alt-text fixture change is invalid on 12.3.x and required on 12.4.x). With this merged, the remaining routine bumps in #471 (Playwright, Vue, prettier, etc.) can land cleanly.