docs: add Notable Changes to Desktop App 7.1.0 release notes#179
Conversation
Add a Notable Changes list to the 7.1.0 entry, matching the format of the existing 6.0.x entries. Surfaces the breaking removals that affect existing users (OC10 support, command-line sync client, bandwidth throttling, suffix VFS plugin), the raised platform minimums (macOS 13, Qt 6.8), and the main UX enhancements. Verified against the upstream owncloud/client CHANGELOG.md at tag v7.1.0. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
DeepDiver1975
left a comment
There was a problem hiding this comment.
🤖 Automated review by Claude Code review agent.
Overview
This PR adds a Notable Changes subsection to the Desktop App 7.1.0 entry in modules/ROOT/pages/desktop_release_notes.adoc, directly addressing the gap flagged in the review of the now-merged #178 (the 7.1.0 entry previously had only the General paragraph and a GitHub changelog link). The change is +15/-0, single file, additive only.
I cross-checked all 11 entries against the upstream source of truth: owncloud/client CHANGELOG.md at tag v7.1.0 (release dated 2026-06-08). Every PR number and description matches the upstream changelog, including exact wording for the macOS/Qt minimums and the wizard/config/management enhancements. Accuracy is solid.
Code quality / style
- AsciiDoc is well-formed:
[discrete]+=== Notable Changesheading and* Change:/* Enhancement:bullets mirror the existing 6.0.x sections exactly. Good consistency. - All 11 inline link macros (
https://...pull/NNNNN[#NNNNN]) are syntactically valid and the link text matches the target PR number in each case. - Section placement is correct: under 7.1.0, above the 6.0.3 section, with the existing IMPORTANT/NOTE admonitions left intact above it.
Specific suggestions (all optional / non-blocking)
- Capitalization of "MacOS" (#12245 bullet). The bullet reads "MacOS 13 is now the minimum supported macOS version" — this faithfully copies the upstream changelog, but the file's own IMPORTANT admonition and the adjacent Qt bullet use the canonical "macOS". Consider normalizing to "macOS 13 ..." for in-page consistency. (Upstream uses "MacOS", so keeping it is defensible — editorial call.)
- Subset selection is reasonable but worth a sanity check. The upstream 7.1.0 changelog lists three additional
Changeitems not surfaced here: Update sync exclusion list for Infinite Scale (#12093), Improve Windows VFS error messages (#12371), and Distinguish moves vs. renames in the activity view (#12494). Omitting bugfix-adjacent/minor changes from a curated "Notable Changes" list is the right editorial choice; flagging only so the omission is known to be deliberate. The OC10-removal bullet appropriately leads the list. - Minor wording nuance (non-blocking). The upstream detail for Qt 6.8 (#12270) notes it "also raises the minimum macOS deployment target to 12," which sits slightly alongside the separate "macOS 13 minimum" bullet (#12245). Both bullets are individually accurate to upstream; no change needed, just noting the two macOS-version statements coexist.
Potential issues / risks
- None blocking. No broken xrefs (all links are external absolute URLs to
owncloud/clientPRs, which resolve), no AsciiDoc parse risks, version string7.1.0and the implied release date (2026-06-08 upstream) are correct, and the change is purely additive so it cannot regress other sections. - Build verification was reported in the PR description (
npm run antora-local, exit 0); the diff contains nothing that would plausibly break the Antora build.
Verdict
Accurate, well-formatted, and faithful to the upstream changelog. Recommend merge. The only nit worth considering before merge is the "MacOS" vs "macOS" casing for in-page consistency.
Use the canonical 'macOS' spelling to match the rest of the page (the IMPORTANT note and the adjacent Qt bullet), per review feedback. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
Follow-up to #178 (merged), addressing the review feedback from review
4526651338.Adds a
Notable Changessubsection to the Desktop App 7.1.0 release-notes entry, matching theformat of the existing 6.0.x entries. The original 7.1.0 entry had only the General paragraph and
GitHub changelog link; this surfaces the items users need to know before upgrading.
Notable Changes (verified against
owncloud/clientCHANGELOG.md@v7.1.0)Breaking removals first, then raised platform minimums, then UX enhancements:
Notes on the other review points
Verification
Built locally with
npm run antora-local(Node 22): exit 0, no log lines referencingdesktop_release_notes.adoc. Confirmed all 11 bullets and their PR links render under 7.1.0,above 6.0.3, with admonitions intact.
🤖 Generated with Claude Code