Skip to content

fix: prevent expense name truncation in group expense list#684

Open
Ziesie1 wants to merge 3 commits into
oss-apps:mainfrom
Ziesie1:text-cut-off
Open

fix: prevent expense name truncation in group expense list#684
Ziesie1 wants to merge 3 commits into
oss-apps:mainfrom
Ziesie1:text-cut-off

Conversation

@Ziesie1

@Ziesie1 Ziesie1 commented Jun 19, 2026

Copy link
Copy Markdown

Description

Currently, long texts are cut off even if there is enough space.
image

Demo

After replacing hardcoded max-w-[180px] with proper flexbox min-w-0 on the text container these bug could be fixed:

image

Checklist

  • [ x ] I have read CONTRIBUTING.md in its entirety
  • [ x ] I have performed a self-review of my own code
  • [ not needed ] I have added unit tests to cover my changes
  • [ x ] The last commit successfully passed pre-commit checks
  • [ x ] Any AI code was thoroughly reviewed by me

Replace hardcoded max-w-[180px] with proper flexbox min-w-0 on the
text container so expense names use all available space before truncating.

@krokosik krokosik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool, I would apply it to the payment string below as well, as it also often gets truncated in an ugly manner (not in your screenshot but I see it quite often)
image

Comment thread src/components/Expense/ExpenseList.tsx Outdated
Comment on lines 155 to 156

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not apply this to settleups as well?

@Ziesie1

Ziesie1 commented Jun 21, 2026

Copy link
Copy Markdown
Author

Good point. With the latest changes, I also fixed the following issues

Fix the description as you also mentioned.
Before:
image
After:
image

Fix the description for setlements as you also mentioned.
Before:
image
After:
image

Fix the description for CurrencyConversion.
Before:
image
Now:
image

I also noted that there are some truncation issues under balances.
Before:
image
After:
image

@krokosik

Copy link
Copy Markdown
Collaborator

I love it! And thank you for the detailed screenshots <3

@krokosik

Copy link
Copy Markdown
Collaborator

I am willing to merge this as is, but if you are willing to process the splitTypeSection dialogs as well, that would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants