Open
Conversation
pipenv 2026.4.0 (released 2026-03-28) changed the hash algorithm to canonicalise package names per PEP 503 before computing the Pipfile hash (pypa/pipenv#4699). Lock files generated by older pipenv recorded the pre-canonicalisation hash and are therefore reported as stale even when the dependency content is unchanged. Running `pipenv lock` with pipenv 2026.4.0 or later regenerates the lock with the canonical hash (64682f1ec0ca…) and also picks up transitive dependency updates accumulated since the last refresh: - cmd2: 3.5.0 → 3.5.1 - cryptography: refreshed artifact hashes (26.1 → 26.2) - setuptools: 46.0.7 → 47.0.0 - certifi: 2026.1 → 2026.2 `pipenv install --dev` and `pipenv install --deploy` now succeed on a fresh checkout of this repo. AI-assisted: Claude Code Signed-off-by: Roger Luethi <luethi@osism.tech>
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since this lockfile was regenerated with pipenv 2026.4.0, consider documenting or pinning that pipenv version in your tooling/CI to avoid future lockfile churn from different pipenv releases recalculating the hash differently.
- Double-check that the
requiressection (e.g.,python_version) and any environment markers in the lockfile still match the project’s intended runtime, so that the regenerated lock doesn’t subtly change supported environments.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since this lockfile was regenerated with pipenv 2026.4.0, consider documenting or pinning that pipenv version in your tooling/CI to avoid future lockfile churn from different pipenv releases recalculating the hash differently.
- Double-check that the `requires` section (e.g., `python_version`) and any environment markers in the lockfile still match the project’s intended runtime, so that the regenerated lock doesn’t subtly change supported environments.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pipfile.lockusing pipenv 2026.4.0, which canonicalises package names per PEP 503 before computing the Pipfile hash (pypa/pipenv#4699)b670465…→64682f1…), causingpipenv install --devandpipenv install --deployto fail on a fresh checkoutcmd23.5.0→3.5.1,cryptographyhash refresh (26.1→26.2),setuptools46.0.7→47.0.0,certifi2026.1→2026.2Test plan
pipenv install --devsucceeds on a fresh checkoutpipenv install --deploysucceeds (lock is not reported as out of date)🤖 Generated with Claude Code