Conversation
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- If
osism.tasks.conductor.utilsexposes a dedicated delete sentinel (e.g. a constant), consider importing and using that instead of the literal "DELETE" in the deep_merge tests to avoid tests silently diverging from the implementation if the sentinel value ever changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- If `osism.tasks.conductor.utils` exposes a dedicated delete sentinel (e.g. a constant), consider importing and using that instead of the literal "DELETE" in the deep_merge tests to avoid tests silently diverging from the implementation if the sentinel value ever changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Covers the five small helpers in osism/tasks/conductor/utils.py with 100% line coverage: deep_compare (diff recording with empty-branch cleanup), deep_merge (recursion plus the "DELETE" sentinel), deep_decrypt (VaultLib mocked, exception-drop semantics for dicts vs. lists), _is_secret_key (password/secret/ironic_osism_ matching) and load_yaml_file (missing/empty/malformed/OSError paths plus vault encrypted/decrypt-failure paths). Out-of-scope conductor helpers stay uncovered as the issue prescribes. Closes #2202 AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the five small helpers in osism/tasks/conductor/utils.py with 100% line coverage: deep_compare (diff recording with empty-branch cleanup), deep_merge (recursion plus the "DELETE" sentinel), deep_decrypt (VaultLib mocked, exception-drop semantics for dicts vs. lists), is_secret_key (password/secret/ironic_osism matching) and load_yaml_file (missing/empty/malformed/OSError paths plus vault encrypted/decrypt-failure paths). Out-of-scope conductor helpers stay uncovered as the issue prescribes.
Closes #2202
AI-assisted: Claude Code