Skip to content

chore: remove X-Ory-SDK header#478

Merged
jonas-jonas merged 1 commit into
masterfrom
jonas-jonas/removeXOrySDK
Jun 25, 2026
Merged

chore: remove X-Ory-SDK header#478
jonas-jonas merged 1 commit into
masterfrom
jonas-jonas/removeXOrySDK

Conversation

@jonas-jonas

@jonas-jonas jonas-jonas commented Jun 25, 2026

Copy link
Copy Markdown
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines
    and signed the CLA.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got approval (please contact
    security@ory.com) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added the necessary documentation within the code base (if
    appropriate).

Further comments

Summary by CodeRabbit

  • Chores

    • Simplified the client generation workflow by removing a post-processing step for generated TypeScript clients.
    • Removed checks related to a generated header injection point in those clients.
  • Documentation

    • Updated an internal comment to describe the SDK user-agent header more precisely.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 534b8feb-db5c-49ec-8740-0a8bf4152e2b

📥 Commits

Reviewing files that changed from the base of the PR and between 1ac66b3 and fe93c28.

📒 Files selected for processing (2)
  • scripts/generate.sh
  • scripts/prep.sh
💤 Files with no reviewable changes (1)
  • scripts/generate.sh

📝 Walkthrough

Walkthrough

The shell scripts stop post-processing generated TypeScript clients to inject an X-Ory-SDK header, and one prep script comment now refers only to the SDK user-agent header.

Changes

Shell script header handling

Layer / File(s) Summary
Remove TypeScript header patching
scripts/generate.sh, scripts/prep.sh
scripts/generate.sh no longer patches typescript-axios or typescript-fetch output to add X-Ory-SDK, and scripts/prep.sh updates the surrounding comment to mention only the SDK user-agent header.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is just the unfilled template comments and lacks the required summary, issue reference, checklist, and further comments. Fill in the PR template with a plain-language change summary, related issue or bug details, completed checklist items, and any relevant notes.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: removing the X-Ory-SDK header.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonas-jonas/removeXOrySDK

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jonas-jonas jonas-jonas merged commit 0aa4d80 into master Jun 25, 2026
5 checks passed
@jonas-jonas jonas-jonas deleted the jonas-jonas/removeXOrySDK branch June 25, 2026 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant