chore(extension): remove dead commented-out referrer capture in http_responses [#1185]#1192
Draft
vringar wants to merge 1 commit into
Draft
chore(extension): remove dead commented-out referrer capture in http_responses [#1185]#1192vringar wants to merge 1 commit into
vringar wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1192 +/- ##
=======================================
Coverage 62.14% 62.14%
=======================================
Files 40 40
Lines 3918 3918
=======================================
Hits 2435 2435
Misses 1483 1483 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…responses [#1185] The response-side handler in http-instrument.ts contained a commented-out block that would have written update.referrer onto the response record. The http_responses table has no referrer column in schema.sql, so this code could never have populated anything. Referrer is captured request-side on http_requests (populated from the Referer request header in onBeforeSendHeadersHandler) and is reachable from an http_responses row via the (visit_id, request_id) join, so duplicating it onto the response record is unnecessary. Replace the dead block with a short note documenting where referrer lives. Closes #1185
vringar
force-pushed
the
cleanup/dead-referrer-capture
branch
from
168bb14 to
27a1d91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the dead commented-out referrer-capture block in the
http_responseshandler inExtension/src/background/http-instrument.ts.The block would have written
update.referreronto the response record, but thehttp_responsestable has noreferrercolumn inschema.sql(nor inparquet_schema.py), so it could never have populated anything.Why this is not a data gap
referreris captured request-side onhttp_requests(columnreferrer TEXT NOT NULL), populated from theRefererrequest header inonBeforeSendHeadersHandler. Referrer is a property of the request, so that is its natural home. For any response, the referrer is recoverable by joininghttp_responsestohttp_requestson(visit_id, request_id)— both tables carry those columns.The dead block is replaced with a short note documenting where referrer lives, so future readers do not mistake it for a missing capture.
Verification
npm run buildcompiles cleanlynpm run lint(ESLint) reports no issuesCloses #1185