Skip to content

fix(workspace): exclude CLI template packages from workspace#351

Merged
SonyLeo merged 1 commit into
opentiny:developfrom
gene9831:fix/lerna-invalid-package-name
May 21, 2026
Merged

fix(workspace): exclude CLI template packages from workspace#351
SonyLeo merged 1 commit into
opentiny:developfrom
gene9831:fix/lerna-invalid-package-name

Conversation

@gene9831
Copy link
Copy Markdown
Collaborator

@gene9831 gene9831 commented May 20, 2026

修复问题:lerna ERR! Error: Invalid package name "__PROJECT_NAME__": name cannot start with an underscore

{EF83269B-6701-4932-8863-90F28928562A}

修改后本地测试 pnpm lerna list --scope=@opentiny/tiny-robot --json

{A135B1B7-0FB2-4E92-AD61-2B8C5192E338}

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9cf48c1f-05cd-4bb0-827b-3087288d6cc2

📥 Commits

Reviewing files that changed from the base of the PR and between 6b5662c and 7b646a2.

📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Walkthrough

This PR updates the pnpm workspace configuration to exclude the packages/cli/templates/** directory from workspace package discovery by adding a negative glob pattern, ensuring template files are not treated as workspace packages.

Changes

Workspace Configuration

Layer / File(s) Summary
Exclude CLI templates from workspace packages
pnpm-workspace.yaml
Negative glob pattern !packages/cli/templates/** is added to the packages array to prevent CLI template directories from being discovered as workspace packages while maintaining the existing packages/** and docs entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through workspace trees,
Trimming templates with practiced ease,
"These seeds," they say, "need not belong,"
One glob, one line, keeps order strong. 🌱✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately describes the main change: excluding CLI template packages from the pnpm workspace configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@SonyLeo SonyLeo merged commit 67f3ee1 into opentiny:develop May 21, 2026
4 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

🧹 Preview Cleaned Up

The preview deployment has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants