Skip to content

Add worker-0 NNCP networking for uni04delta-adoption#768

Open
fyanac wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fyanac:worker_delta_ipv4
Open

Add worker-0 NNCP networking for uni04delta-adoption#768
fyanac wants to merge 1 commit into
openstack-k8s-operators:mainfrom
fyanac:worker_delta_ipv4

Conversation

@fyanac

@fyanac fyanac commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Following configuration from other adoptions jobs that use worker-0 like uni02beta and uni04delta-ipv6.

Related to OSPRH-31782

Assisted-By: Cursor-composer-2-fast

@openshift-ci

openshift-ci Bot commented Jun 17, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Following configuration from other adoptions jobs that use worker-0
like uni02beta and uni04delta-ipv6.

Assisted-By: Cursor-composer-2-fast
@fyanac fyanac force-pushed the worker_delta_ipv4 branch from 8d9fb3b to d09a0c1 Compare June 17, 2026 12:53
@fyanac fyanac marked this pull request as ready for review June 24, 2026 09:29
@fyanac fyanac requested a review from a team as a code owner June 24, 2026 09:29
@openshift-ci openshift-ci Bot requested review from leifmadsen and raukadah June 24, 2026 09:29
@fyanac fyanac added the ready-review Request is ready to be reviewed label Jun 24, 2026
@vhariria

vhariria commented Jun 24, 2026

Copy link
Copy Markdown

@fyanac hi, please note that the ocp-3 networks MACs hardcoded to titan73 hardware (e.g. 52:54:02:18:86:bc) is an issue. It breaks OCP deploy on other hypervisors where those MACs don't exist.

@fyanac

fyanac commented Jun 24, 2026

Copy link
Copy Markdown
Contributor Author

@fyanac hi, please note that the ocp-3 networks MACs hardcoded to titan73 hardware (e.g. 52:54:02:18:86:bc) is an issue. It breaks OCP deploy on other hypervisors where those MACs don't exist.

Hi, this is not hardcode for that host specifically.
I get similar worker-0 config from unidelta-ipv6: https://github.com/openstack-k8s-operators/architecture/blob/main/automation/net-env/uni04delta-ipv6-adoption.yaml#L431

@fyanac

fyanac commented Jun 26, 2026

Copy link
Copy Markdown
Contributor Author

This patch was tested ok by different host.

@jistr jistr left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fyanac, jistr
Once this PR has been reviewed and has the lgtm label, please assign abays for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm ready-review Request is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants