Skip to content

Add variable to ppc64le jobs #80956

Open
aishwaryabk wants to merge 1 commit into
openshift:mainfrom
aishwaryabk:ppc-5.0
Open

Add variable to ppc64le jobs #80956
aishwaryabk wants to merge 1 commit into
openshift:mainfrom
aishwaryabk:ppc-5.0

Conversation

@aishwaryabk

@aishwaryabk aishwaryabk commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Updates the openshift/openshift-tests-private ppc64le nightly CI config to set OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY for PowervS IPI jobs. This changes how those PowerVS test jobs handle image policy during installation: the non-destructive job enables the setting, while the destructive variant explicitly clears it.

Signed-off-by: Aishwarya Kamat <aishwarya.kamat@ibm.com>
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b080e0a2-549a-491f-86db-083e948cf69d

📥 Commits

Reviewing files that changed from the base of the PR and between 495ca49 and a146b53.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__ppc64le-nightly.yaml

Walkthrough

Two PowerVS IPI test entries in the ppc64le nightly CI config (powervs-ipi-f7 and powervs-ipi-f7-destructive) each receive a new environment variable OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY. The non-destructive entry sets it to "true"; the destructive entry sets it to "".

Changes

PowerVS IPI ppc64le Nightly Config

Layer / File(s) Summary
Env var addition for powervs-ipi-f7 and powervs-ipi-f7-destructive
ci-operator/config/openshift/openshift-tests-private/openshift-openshift-tests-private-release-5.0__ppc64le-nightly.yaml
OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY is added to both test step env blocks: "true" for the non-destructive entry and "" for the destructive entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding an environment variable to ppc64le jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only ci-operator YAML env vars changed; no Ginkgo It/Describe/Context/When titles were added or edited.
Test Structure And Quality ✅ Passed PASS: PR only updates ci-operator job env vars in a YAML config; no Ginkgo test code, setup/cleanup, or assertions were changed.
Microshift Test Compatibility ✅ Passed The PR only adds an env var to two ci-operator job configs; no new Ginkgo tests, APIs, or MicroShift-sensitive code were introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Only CI YAML env vars changed; no new It/Describe/Context tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only adds an installer env var in ci-operator test config; it does not touch deployment manifests, operators, or any scheduling constraints.
Ote Binary Stdout Contract ✅ Passed PR only updates CI YAML env vars for PowervS jobs; no OTE binary code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Only ci-operator job env vars changed in a YAML config; no new Ginkgo tests or IPv4/external network logic were introduced.
No-Weak-Crypto ✅ Passed The only change adds OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY to PowervS jobs; no weak-crypto APIs or secret comparisons are introduced.
Container-Privileges ✅ Passed The change only adds OPENSHIFT_INSTALL_EXPERIMENTAL_DISABLE_IMAGE_POLICY env vars; no privileged, hostPID/Network/IPC, SYS_ADMIN, root, or allowPrivilegeEscalation fields appear.
No-Sensitive-Data-In-Logs ✅ Passed The change only adds an env var to two PowervS job configs; no new logging, secrets, tokens, or PII appear in the diff.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aishwaryabk
Once this PR has been reviewed and has the lgtm label, please assign amoghrd for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@aishwaryabk: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-openshift-tests-private-release-5.0-ppc64le-nightly-powervs-ipi-f7-destructive N/A periodic Ci-operator config changed
periodic-ci-openshift-openshift-tests-private-release-5.0-ppc64le-nightly-powervs-ipi-f7 N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@aishwaryabk: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@aishwaryabk

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-openshift-tests-private-release-5.0-ppc64le-nightly-powervs-ipi-f7

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@aishwaryabk: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant