Skip to content

AUTOSCALE-810: add karpenter-operator operator job#80954

Open
maxcao13 wants to merge 1 commit into
openshift:mainfrom
maxcao13:add-karpenter-operator-e2e
Open

AUTOSCALE-810: add karpenter-operator operator job#80954
maxcao13 wants to merge 1 commit into
openshift:mainfrom
maxcao13:add-karpenter-operator-e2e

Conversation

@maxcao13

@maxcao13 maxcao13 commented Jun 24, 2026

Copy link
Copy Markdown
Member

Adds a e2e job that tests operator functionality for the karpenter-operator.

Summary by CodeRabbit

This change updates the karpenter-operator OpenShift CI configuration by adding a new end-to-end operator test workflow entry (e2e-aws-operator). Practically, it gives the karpenter-operator repo dedicated operator E2E coverage by running make e2e against the src directory under an ipi-aws workflow, using the same existing AWS E2E gating (skip_if_only_changed) and environment (cluster_profile/FEATURE_SET) while setting a lightweight CPU request (resources.requests.cpu: 100m).

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 24, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@maxcao13: This pull request references AUTOSCALE-810 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Adds a e2e job that tests operator functionality for the karpenter-operator.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maxcao13 maxcao13 marked this pull request as draft June 24, 2026 07:20
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8d50c2d0-7f06-42fd-8409-3c9824acea60

📥 Commits

Reviewing files that changed from the base of the PR and between 3c86d67 and 01395a9.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/openshift/karpenter-operator/openshift-karpenter-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-main.yaml

Walkthrough

A new test job e2e-aws-operator is added to the CI configuration for the OpenShift Karpenter operator. It uses the ipi-aws workflow, runs make e2e from the src directory with 100m CPU, and shares the same cluster_profile, FEATURE_SET, and skip_if_only_changed pattern as the existing e2e-aws job.

Changes

Karpenter Operator CI Configuration

Layer / File(s) Summary
e2e-aws-operator job definition
ci-operator/config/openshift/karpenter-operator/openshift-karpenter-operator-main.yaml
Adds the e2e-aws-operator test job with ipi-aws workflow, aws cluster profile, TechPreviewNoUpgrade feature set, a nested test step running make e2e from src with resources.requests.cpu: 100m, and the same skip_if_only_changed regex as the sibling e2e-aws job.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding a new karpenter-operator job to CI configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a CI YAML job definition was added; no Ginkgo It/Describe/Context/When titles were changed, so no unstable test names are present.
Test Structure And Quality ✅ Passed Only CI config changed; no Ginkgo test files or operator test code were added, so the test-quality review is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo test code changed; the PR only adds CI job config, so there’s nothing new to assess for MicroShift API compatibility.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds CI job wiring; no new Ginkgo test code or SNO-sensitive specs were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Only a CI test job was added in a YAML config; no deployment manifests, controllers, or topology-sensitive scheduling logic changed.
Ote Binary Stdout Contract ✅ Passed The PR only adds a CI config job in YAML; no process-level binary code or stdout logging was introduced.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds CI config for an existing make e2e job; the changed YAML contains no Ginkgo test code, IPv4 literals, or public-internet dependencies.
No-Weak-Crypto ✅ Passed Changed file is CI YAML only; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons found.
Container-Privileges ✅ Passed The added e2e-aws-operator job contains no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR only adds a CI test entry in YAML; it contains no log statements or sensitive literals like tokens, passwords, emails, or hostnames.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2026
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maxcao13

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from elmiko and jkyros June 24, 2026 07:21
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2026
Signed-off-by: Max Cao <macao@redhat.com>
@maxcao13 maxcao13 force-pushed the add-karpenter-operator-e2e branch from 3c86d67 to 01395a9 Compare June 24, 2026 07:22
@maxcao13 maxcao13 marked this pull request as ready for review June 24, 2026 07:22
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 24, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-karpenter-operator-main-e2e-operator openshift/karpenter-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci openshift-ci Bot requested a review from joelsmith June 24, 2026 07:23
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@maxcao13: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-karpenter-operator-main-e2e-aws-operator openshift/karpenter-operator presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@maxcao13

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-karpenter-operator-main-e2e-aws-operator

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@maxcao13

Copy link
Copy Markdown
Member Author

/pj-rehearse pull-ci-openshift-karpenter-operator-main-e2e-aws-operator

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@maxcao13: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@maxcao13: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/karpenter-operator/main/e2e-aws-operator 01395a9 link unknown /pj-rehearse pull-ci-openshift-karpenter-operator-main-e2e-aws-operator

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants