Gather agent log bundle#80950
Conversation
openshift-ci
Bot
added
the
approved
WalkthroughThe agent gather script now copies remote ChangesAgent Gather Artifact Publishing
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
In GUI agent-based installs, include the log bundle downloaded from the GUI in the CI artifacts to ease debugging.
The screenshot archive is retrieved by the scp from the dev-scripts host, by virtue of the filename agent-gather-console-screenshots.tar.xz matching the glob agent-gather*.tar.xz. It is not present in the CI container where the agent-gather-commands.sh script is running, and logs show that the code removed here was not actually running (the log "gathered agent-gather-console-screenshots.tar.xz" does not appear, despite the screenshot archive appearing in the artifacts).
zaneb
force-pushed
the
agent-gather-installation-logs
branch
from
821279a to
495732e
Compare
|
[REHEARSALNOTIFIER]
A total of 573 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/step-registry/agent/gather/agent-gather-commands.sh`:
- Around line 18-20: The combined scp in agent_gather_commands.sh currently ties
the required agent-gather archive transfer to the optional installation-logs
bundle, so a missing bundle can fail the whole publish step. Split the copy
logic in the agent log publishing block into two separate scp operations: keep
the agent-gather*.tar.xz copy as required, and make the installation-logs.tar
copy in the ocp/* path best-effort so it does not block artifact publication.
Preserve the existing success message behavior around the gather archive copy in
the same script.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: bebc822d-a898-4c60-a0f6-b4ddfa30cc76
📒 Files selected for processing (1)
ci-operator/step-registry/agent/gather/agent-gather-commands.sh
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/pj-rehearse pull-ci-openshift-assisted-installer-agent-master-e2e-agent-compact-ipv4 pull-ci-openshift-assisted-installer-agent-master-e2e-agent-compact-ipv4-iso-noregistry |
|
@zaneb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@zaneb: job(s): pull-ci-openshift-assisted-installer-agent-master-e2e-agent-compact-ipv4-iso-noregistry either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-iso-noregistry |
|
@zaneb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@zaneb: job(s): pull-ci-openshift-installer-master-e2e-agent-compact-ipv4-iso-noregistry either don't exist or were not found to be affected, and cannot be rehearsed |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-agent-compact-ipv4-iso-no-registry |
|
@zaneb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andfasano, zaneb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse pull-ci-openshift-installer-main-e2e-agent-compact-ipv4 |
|
@zaneb: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@zaneb: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
In GUI agent-based installs, include the log bundle downloaded from the GUI in the CI artifacts to ease debugging.
This replaces the change that was reverted in openshift-metal3/dev-scripts#1899. Because of OCPBUGS-91975 and OCPBUGS-91982, the log bundle is currently being redacted. Including this in the screenshot archive meant that the screenshots were effectively redacted also, but copying it as a separate artifact means that they will be treated independently.
Summary by CodeRabbit
This changes the OpenShift CI “agent gather” step so GUI/agent-based installs now publish the downloaded installation log bundle as part of the CI artifacts. Concretely, the step’s
scpnow copies bothagent-gather*.tar.xzand/root/dev-scripts/ocp/*/installation-logs.tarfrom the target host into${ARTIFACT_DIR}, and only reports success when the copy succeeds—otherwise it skips publishing the log bundle.By keeping the installation logs bundled separately from the screenshot archive, it avoids the earlier redaction side effects where packaging them together caused screenshots to be redacted.