Skip to content

WIP: ci-operator/kubernetes: target rhel-coreos-10 for RHCOS overlay on master#80945

Open
jubittajohn wants to merge 1 commit into
openshift:mainfrom
jubittajohn:fix-rhel-coreos-10-overlay-tag
Open

WIP: ci-operator/kubernetes: target rhel-coreos-10 for RHCOS overlay on master#80945
jubittajohn wants to merge 1 commit into
openshift:mainfrom
jubittajohn:fix-rhel-coreos-10-overlay-tag

Conversation

@jubittajohn

@jubittajohn jubittajohn commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

This PR updates OpenShift CI infrastructure to run the Kubernetes master branch RHCOS overlay tests against RHEL CoreOS 10 instead of the unversioned RHCOS base.

  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml: switches the RHCOS RPM-injected/overlay image reference to target the output image name rhel-coreos-10 (replacing the previous rhel-coreos), so the master pipeline builds/uses the RHEL CoreOS 10–based overlay for Kubernetes RPM validation.
  • core-services/image-mirroring/openshift/mapping_origin_scos-4_17: extends the image mirroring mapping to include origin_scos-4.17_rhel-coreos-10quay.io/openshift/origin-rhel-coreos-10 for 4.17 and 4.17.0, ensuring the new RHCOS 10 image variant is correctly mirrored for that release line.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2026
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 53f5528d-6517-4925-b862-f63167882fab

📥 Commits

Reviewing files that changed from the base of the PR and between 1fbcd13 and 3439833.

📒 Files selected for processing (2)
  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml
  • core-services/image-mirroring/openshift/mapping_origin_scos-4_17
✅ Files skipped from review due to trivial changes (1)
  • core-services/image-mirroring/openshift/mapping_origin_scos-4_17
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml

Walkthrough

The output image name for the RHCOS RPM-injected image build is changed from rhel-coreos to rhel-coreos-10 in the CI operator configuration, and a corresponding image mirror mapping is added to distribute the renamed image via quay.io.

Changes

RHCOS Image Configuration Updates

Layer / File(s) Summary
Image output rename and mirror mapping configuration
ci-operator/config/openshift/kubernetes/openshift-kubernetes-master.yaml, core-services/image-mirroring/openshift/mapping_origin_scos-4_17
The CI operator configuration changes the to field in the images entry from rhel-coreos to rhel-coreos-10, and the image-mirroring configuration adds a new mapping line for origin_scos-4.17_rhel-coreos-10 pointing to quay.io/openshift/origin-rhel-coreos-10 with tags 4.17 and 4.17.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • deepsm007
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: targeting rhel-coreos-10 for RHCOS overlay in the master/kubernetes configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR contains no Ginkgo test code - only CI/CD configuration files (YAML image definitions and image mirroring mappings). Check is not applicable.
Test Structure And Quality ✅ Passed The PR contains no Ginkgo test code. Changes are exclusively to YAML configuration files (ci-operator config and image mirroring mapping), not test code. The custom check does not apply.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests are present in this PR. Changes are limited to CI operator configuration (YAML) and image mapping files with no test code.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies CI operator configuration files (YAML and image mapping files). No Ginkgo e2e tests are added, so the SNO compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed Changes are CI configuration and image-mirroring mappings; they do not introduce deployment manifests, operator code, or scheduling constraints affecting topology compatibility.
Ote Binary Stdout Contract ✅ Passed PR contains only YAML configuration and documentation changes; no Go source code or OTE binary code present, making the OTE Binary Stdout Contract check inapplicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo e2e tests (It(), Describe(), Context(), When()) are added in this PR. Changes are limited to CI configuration files and standard Go unit tests, which are outside the scope of this IPv6/di...
No-Weak-Crypto ✅ Passed PR contains only YAML/configuration file changes for CI image naming and mapping; no cryptographic code, weak crypto algorithms (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto, or token c...
Container-Privileges ✅ Passed No privileged container settings (privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, runAsRoot) found in modified CI-Operator config or image mapping files.
No-Sensitive-Data-In-Logs ✅ Passed No logging that exposes sensitive data detected. PR contains configuration file updates and documentation; no code changes with logging statements that leak passwords, tokens, API keys, PII, or oth...

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@openshift-ci openshift-ci Bot requested review from benluddy and jerpeter1 June 23, 2026 21:08
Signed-off-by: jubittajohn <jujohn@redhat.com>
@jubittajohn jubittajohn force-pushed the fix-rhel-coreos-10-overlay-tag branch from 1fbcd13 to 3439833 Compare June 23, 2026 21:29
@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jubittajohn
Once this PR has been reviewed and has the lgtm label, please assign jupierce for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jubittajohn: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kubernetes-master-artifacts openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-configmap-scale openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-agnostic-ovn-cmd openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-csi openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-disruptive openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-hpa openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-jenkins openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2 openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-downgrade openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-hypershift openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-runc openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial-1of2 openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial-2of2 openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-techpreview openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-techpreview-serial-1of2 openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-techpreview-serial-2of2 openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-ovn-upgrade openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-aws-single-node openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-azure openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-azure-ovn-upgrade openshift/kubernetes presubmit Ci-operator config changed
pull-ci-openshift-kubernetes-master-e2e-external-aws-ccm openshift/kubernetes presubmit Ci-operator config changed

A total of 49 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-downgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-serial

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-cgroupsv2

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-crun

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-downgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-hypershift

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial-1of2

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-serial-2of2

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-techpreview

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-techpreview-serial-1of2

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-techpreview-serial-2of2

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-azure-ovn-upgrade

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-e2e-gcp

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-k8s-e2e-conformance-aws

@jubittajohn

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-kubernetes-master-k8s-e2e-gcp-ovn

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

1 similar comment
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@jubittajohn: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@jubittajohn: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/kubernetes/master/e2e-aws-ovn-fips 3439833 link unknown /pj-rehearse pull-ci-openshift-kubernetes-master-e2e-aws-ovn-fips

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant