Skip to content

Add cs-sanity-jira-staging manual job and remove periodic scheduling#80942

Open
jfrazierRedHat wants to merge 1 commit into
openshift:mainfrom
jfrazierRedHat:jf_jira_check
Open

Add cs-sanity-jira-staging manual job and remove periodic scheduling#80942
jfrazierRedHat wants to merge 1 commit into
openshift:mainfrom
jfrazierRedHat:jf_jira_check

Conversation

@jfrazierRedHat

@jfrazierRedHat jfrazierRedHat commented Jun 23, 2026

Copy link
Copy Markdown
Contributor
  • Add new manual job ocm-fvt-periodic-cs-sanity-jira-staging-main
  • Remove interval from both sanity jobs so they only run on manual trigger
  • Both cs-sanity-staging and cs-sanity-jira-staging are now manual-only

Summary by CodeRabbit

This PR updates the OpenShift CI ROSA E2E (rosa-hcp-staging) job configuration to change how the periodic cluster sanity checks run.

Key changes

  • Added a new manual sanity job: ocm-fvt-periodic-cs-sanity-jira-staging-main, wired to run the rosa-e2e-ocm-fvt suite with OCM_FVT_JOB_NAME=cs-sanity-jira-staging, including nested-podman (nested_podman: true) and a 5h0m0s timeout.
  • Removed interval-based scheduling for sanity checks: the periodic scheduling interval (interval: 168h) is removed so these jobs no longer run on an automatic schedule and instead execute only when manually triggered:
    • ocm-fvt-periodic-cs-sanity-staging-main
    • ocm-fvt-periodic-cs-sanity-jira-staging-main (as configured by the new manual job entry)

Impact

  • ROSA HCP staging “CS sanity” tests are now on-demand/manual rather than weekly periodic, enabling more controlled execution and resource usage.

@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 91597db1-c977-4e55-8262-93e625b5b18a

📥 Commits

Reviewing files that changed from the base of the PR and between d36b143 and 1154e45.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-staging.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-staging.yaml

Walkthrough

The ROSA E2E HCP staging CI config removes the interval: 168h field from the ocm-fvt-periodic-cs-sanity-staging-main job and adds a new periodic job ocm-fvt-periodic-cs-sanity-jira-staging-main with nested-podman enabled, standard pre/post steps, and a 5-hour timeout.

Changes

ROSA HCP Staging Periodic Jobs

Layer / File(s) Summary
Interval removal and new Jira sanity job
ci-operator/config/openshift-online/rosa-e2e/openshift-online-rosa-e2e-main__ocm-fvt-rosa-hcp-staging.yaml
Removes interval: 168h from ocm-fvt-periodic-cs-sanity-staging-main. Adds ocm-fvt-periodic-cs-sanity-jira-staging-main with nested-podman capability, nested_podman: true, pre step rosa-e2e-record-start-time, post step rosa-e2e-collect-cs-telemetry, test ref rosa-e2e-ocm-fvt, OCM_FVT_JOB_NAME: cs-sanity-jira-staging, and timeout: 5h0m0s.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Suggested reviewers

  • ravitri
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: adding a new cs-sanity-jira-staging manual job and removing periodic scheduling from sanity check jobs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only modifies YAML CI/CD configuration file with no Ginkgo test code; custom check for test names is not applicable to non-test files.
Test Structure And Quality ✅ Passed This PR modifies only CI/CD job configuration YAML files, not Ginkgo test code. The custom check for test code quality is not applicable to this PR.
Microshift Test Compatibility ✅ Passed This PR modifies CI configuration files (YAML job definitions), not Ginkgo e2e test code. The custom check applies only to new Ginkgo tests; no new tests are added in this PR.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR modifies a CI job configuration YAML file, not Ginkgo test code. The check is for new e2e tests with multi-node assumptions; no test code is added here.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies a CI operator configuration file that defines test job scheduling, not a Kubernetes deployment manifest or operator code. The file contains no pod scheduling constraints (affinity,...
Ote Binary Stdout Contract ✅ Passed PR modifies only YAML CI/CD configuration files, not Go source code. OTE Binary Stdout Contract check applies to process-level Go code (main, init, test suites), which is absent from this PR's chan...
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies CI job configuration YAML, not Ginkgo test code. Check applies only when new e2e tests (It(), Describe(), etc.) are added, which this PR does not do.
No-Weak-Crypto ✅ Passed The pull request modifies a YAML CI/CD configuration file with no cryptographic implementations or weak crypto patterns; no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB mode, custom crypto, or insecure...
Container-Privileges ✅ Passed The PR modifies a CI/CD config file, adding a test job with the nested-podman capability. No privileged containers, hostPID, hostNetwork, hostIPC, SYS_ADMIN capabilities, or allowPrivilegeEscalatio...
No-Sensitive-Data-In-Logs ✅ Passed YAML configuration file contains no passwords, tokens, API keys, PII, session IDs, internal hostnames, or sensitive customer data. Job identifiers and environment variables are non-sensitive metadata.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from gdbranco and tiwillia June 23, 2026 19:23
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 23, 2026
- Add new manual job ocm-fvt-periodic-cs-sanity-jira-staging-main
- Remove interval from both sanity jobs so they only run on manual trigger
- Both cs-sanity-staging and cs-sanity-jira-staging are now manual-only

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@dustman9000

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustman9000, jfrazierRedHat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 23, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@jfrazierRedHat: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-staging-ocm-fvt-periodic-cs-sanity-jira-staging-main openshift-online/rosa-e2e presubmit Presubmit changed
pull-ci-openshift-online-rosa-e2e-main-ocm-fvt-rosa-hcp-staging-ocm-fvt-periodic-cs-sanity-staging-main openshift-online/rosa-e2e presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@jfrazierRedHat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants