add srelib poc #922
+123
−30
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,55 @@ | ||||||||||||||||
| package srelib | ||||||||||||||||
|
|
||||||||||||||||
| import ( | ||||||||||||||||
| "fmt" | ||||||||||||||||
| "os/exec" | ||||||||||||||||
|
|
||||||||||||||||
| "github.com/hashicorp/go-hclog" | ||||||||||||||||
| "github.com/hashicorp/go-plugin" | ||||||||||||||||
| cmv1 "github.com/openshift-online/ocm-sdk-go/clustersmgmt/v1" | ||||||||||||||||
|
|
||||||||||||||||
| "github.com/petrkotas/srelib/sdk" | ||||||||||||||||
| v1 "github.com/petrkotas/srelib/sdk/v1" | ||||||||||||||||
| ) | ||||||||||||||||
|
|
||||||||||||||||
| type Client struct { | ||||||||||||||||
| inner v1.Client | ||||||||||||||||
| killer *plugin.Client | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| func NewClient(pluginPath string) (*Client, error) { | ||||||||||||||||
| pc := plugin.NewClient(&plugin.ClientConfig{ | ||||||||||||||||
| HandshakeConfig: sdk.HandshakeConfig, | ||||||||||||||||
| VersionedPlugins: map[int]plugin.PluginSet{ | ||||||||||||||||
| 1: {"srelib": &v1.Plugin{}}, | ||||||||||||||||
| }, | ||||||||||||||||
| Cmd: exec.Command(pluginPath), | ||||||||||||||||
| Logger: hclog.New(&hclog.LoggerOptions{Name: "srelib", Level: hclog.Error}), | ||||||||||||||||
| }) | ||||||||||||||||
|
|
||||||||||||||||
| rpcClient, err := pc.Client() | ||||||||||||||||
| if err != nil { | ||||||||||||||||
| pc.Kill() | ||||||||||||||||
| return nil, fmt.Errorf("srelib: connect to plugin: %w", err) | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| raw, err := rpcClient.Dispense("srelib") | ||||||||||||||||
| if err != nil { | ||||||||||||||||
| pc.Kill() | ||||||||||||||||
| return nil, fmt.Errorf("srelib: dispense plugin: %w", err) | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| return &Client{inner: raw.(v1.Client), killer: pc}, nil | ||||||||||||||||
|
There was a problem hiding this comment. 🧩 Analysis chain🏁 Script executed: find . -type f -name "client.go" | grep srelibRepository: openshift/osdctl Length of output: 83 🏁 Script executed: head -60 pkg/srelib/client.go | cat -nRepository: openshift/osdctl Length of output: 1697 Unguarded type assertion from plugin dispense can panic.
Proposed fix- return &Client{inner: raw.(v1.Client), killer: pc}, nil
+ inner, ok := raw.(v1.Client)
+ if !ok {
+ pc.Kill()
+ return nil, fmt.Errorf("srelib: unexpected plugin client type %T", raw)
+ }
+ return &Client{inner: inner, killer: pc}, nil📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| func (c *Client) GetClusters(ids []string) ([]*cmv1.Cluster, error) { | ||||||||||||||||
| return c.inner.GetClusters(ids) | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| func (c *Client) GetClusterAnyStatus(id string) (*cmv1.Cluster, error) { | ||||||||||||||||
| return c.inner.GetClusterAnyStatus(id) | ||||||||||||||||
| } | ||||||||||||||||
|
|
||||||||||||||||
| func (c *Client) Close() { | ||||||||||||||||
| c.killer.Kill() | ||||||||||||||||
| } | ||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/osdctl
Length of output: 425
Remove local
replacedirective; it blocks builds in any clean environment.replace github.com/petrkotas/srelib => ../srelibwill fail immediately on CI systems and consumer builds since../srelibis absent from the repository. This is a build blocker, not just a reproducibility issue. Either remove the replace directive or reference a resolvable module version (published release, commit-based pseudo-version, or git branch).Per supply chain security guidelines, all dependency references must be reproducible and pinnable. Local filesystem paths violate this requirement and must not reach production.
🤖 Prompt for AI Agents
Source: Coding guidelines