Skip to content

Upgrade js-cookie to 3.0.7#2132

Open
kyoto wants to merge 1 commit into
openshift:mainfrom
kyoto:js-cookie-3.0.7
Open

Upgrade js-cookie to 3.0.7#2132
kyoto wants to merge 1 commit into
openshift:mainfrom
kyoto:js-cookie-3.0.7

Conversation

@kyoto

@kyoto kyoto commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Updated dependency resolution to pin js-cookie to a specific version for more consistent behavior and stability.

@kyoto kyoto added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 24, 2026
@openshift-ci openshift-ci Bot requested review from joshuawilson and xrajesh June 24, 2026 06:51
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci

openshift-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto

kyoto commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

/cherry-pick release-4.19

@openshift-cherrypick-robot

Copy link
Copy Markdown

@kyoto: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1a0ef785-7c5b-486b-a55b-a1dc97833ed8

📥 Commits

Reviewing files that changed from the base of the PR and between ab1ee42 and f786651.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • package.json

📝 Walkthrough

Walkthrough

A single overrides entry is added to package.json that pins the js-cookie transitive dependency to version 3.0.7. No other configuration, scripts, or dependencies are changed.

Changes

Dependency Override

Layer / File(s) Summary
Pin js-cookie to 3.0.7
package.json
Adds js-cookie@3.0.7 to the overrides section, forcing all transitive consumers to resolve to that version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A cookie once roamed wild and free,
bouncing through versions with glee,
🐇 But the rabbit said "Stop!
At three-oh-seven we'll hop,
Stay pinned, little cookie — trust me!"

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: pinning js-cookie to version 3.0.7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants