OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/#16384
OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/#16384cajieh wants to merge 1 commit intoopenshift:mainfrom
Conversation
…ocales/en/ Adding latest translations from Memsource project https://cloud.memsource.com/web/project2/show/IjrLfI0tmESSiOSwai9SQ2
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cajieh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/jira refresh |
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test backend |
|
@cajieh: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is valid. 3 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Analysis / Root cause:
Following recent updates to the vSphere plugin, a regression was identified where several localized strings were removed or omitted from the locales/en/ source directory despite remaining active in the component implementation.
This resulted in:
Broken Translations: Missing keys caused the UI to fallback to raw key names or empty strings in non-English locales.
Sync Mismatch: The Phrase (Memsource) portal lacked these keys, preventing the localization team from providing translations for upcoming releases.
Solution description:
Source Restoration: Re-introduced the missing string keys into frontend/public/locales/en/vsphere-plugin.json to align the locale source with the current code implementation.
Phrase Portal Sync: Will be uploaded to portal later on.
Test setup:
Clean the local environment:
rm -rf node_modules && yarn install && yarn i18nEnsure the vSphere plugin is enabled in your local development environment.
Test cases:
Key Verification: Verify that the "Error loading" and other vSphere-specific messages no longer show raw translation keys in the console or UI.
Locale Switching: Switch the console language to a supported secondary language (e.g., French) and verify that the keys now appear (either as the restored English string or the translated version if already available in the portal).
Build Integrity: Run
yarn buildto ensure that the i18n asset compilation completes without errors.Screenshots
Reviewers and assignees: