Skip to content

OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/#16384

Open
cajieh wants to merge 1 commit intoopenshift:mainfrom
cajieh:OCPBUGS-84844
Open

OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/#16384
cajieh wants to merge 1 commit intoopenshift:mainfrom
cajieh:OCPBUGS-84844

Conversation

@cajieh
Copy link
Copy Markdown
Contributor

@cajieh cajieh commented Apr 30, 2026

Analysis / Root cause:

Following recent updates to the vSphere plugin, a regression was identified where several localized strings were removed or omitted from the locales/en/ source directory despite remaining active in the component implementation.

This resulted in:
Broken Translations: Missing keys caused the UI to fallback to raw key names or empty strings in non-English locales.

Sync Mismatch: The Phrase (Memsource) portal lacked these keys, preventing the localization team from providing translations for upcoming releases.

Solution description:

Source Restoration: Re-introduced the missing string keys into frontend/public/locales/en/vsphere-plugin.json to align the locale source with the current code implementation.

Phrase Portal Sync: Will be uploaded to portal later on.

Test setup:

Clean the local environment: rm -rf node_modules && yarn install && yarn i18n

Ensure the vSphere plugin is enabled in your local development environment.

Test cases:
Key Verification: Verify that the "Error loading" and other vSphere-specific messages no longer show raw translation keys in the console or UI.

Locale Switching: Switch the console language to a supported secondary language (e.g., French) and verify that the keys now appear (either as the restored English string or the translated version if already available in the portal).

Build Integrity: Run yarn build to ensure that the i18n asset compilation completes without errors.

Screenshots

Reviewers and assignees:

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 30, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

Solution description:

Screenshots / screen recording:

Test setup:

Test cases:

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from rawagner and rhamilto April 30, 2026 21:09
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added component/core Related to console core functionality kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 30, 2026
@cajieh
Copy link
Copy Markdown
Contributor Author

cajieh commented Apr 30, 2026

/jira refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is invalid:

  • expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh
Copy link
Copy Markdown
Contributor Author

cajieh commented Apr 30, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh
Copy link
Copy Markdown
Contributor Author

cajieh commented May 1, 2026

/test backend

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 1, 2026

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@cajieh cajieh changed the title [WIP] OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/ OCPBUGS-84844: VSphere plugin changes broke i18n translations - missing strings in locales/en/ May 1, 2026
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-84844, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Analysis / Root cause:

Following recent updates to the vSphere plugin, a regression was identified where several localized strings were removed or omitted from the locales/en/ source directory despite remaining active in the component implementation.

This resulted in:
Broken Translations: Missing keys caused the UI to fallback to raw key names or empty strings in non-English locales.

Sync Mismatch: The Phrase (Memsource) portal lacked these keys, preventing the localization team from providing translations for upcoming releases.

Solution description:

Source Restoration: Re-introduced the missing string keys into frontend/public/locales/en/vsphere-plugin.json to align the locale source with the current code implementation.

Phrase Portal Sync: Will be uploaded to portal later on.

Test setup:
Clean the local environment: rm -rf node_modules && yarn install && yarn i18n

Ensure the vSphere plugin is enabled in your local development environment.

Test cases:
Key Verification: Verify that the "Error loading" and other vSphere-specific messages no longer show raw translation keys in the console or UI.

Locale Switching: Switch the console language to a supported secondary language (e.g., French) and verify that the keys now appear (either as the restored English string or the translated version if already available in the portal).

Build Integrity: Run yarn build to ensure that the i18n asset compilation completes without errors.

Reviewers and assignees:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants