Skip to content

OCPBUGS-84324: Update outdated documentation links and references#16362

Open
fsgreco wants to merge 2 commits intoopenshift:mainfrom
fsgreco:OCPBUGS-84324--main-branch--fix-guidelines
Open

OCPBUGS-84324: Update outdated documentation links and references#16362
fsgreco wants to merge 2 commits intoopenshift:mainfrom
fsgreco:OCPBUGS-84324--main-branch--fix-guidelines

Conversation

@fsgreco
Copy link
Copy Markdown
Contributor

@fsgreco fsgreco commented Apr 28, 2026

  • Fix 404 links and redirects on README file
  • Fix outdated CI manifest reference to use main branch in README file

Jira bug: https://issues.redhat.com/browse/OCPBUGS-84324

Analysis / Root cause:
Some links in the project's main documentation files (README.md, CONTRIBUTING.md, STYLEGUIDE.md) are broken, redirecting, or outdated. These create a poor onboarding experience for new contributors and can lead to confusion when following setup instructions.

Additional info:
Redirects are not necessarily a 'not found' case per se, but they could eventually become invalid in the future; therefore, it is better to replace them with their current URLs if possible.

Reviewers and assignees:

Docs approver:
/assign @Leo6Leo

Summary by CodeRabbit

  • Documentation
    • Updated contributing guide to reference the current main branch workflow and backport order
    • Updated external resource links (Go, Go modules, kubectl, CodeReady Containers) and CI presubmit reference to main
    • Clarified jq usage in scripts and tests with a code-usage link
    • Switched style guide BEM reference to HTTPS for improved link security

- Fix 404 links and redirects on README file
- Fix outdated CI manifest reference to use main branch in README file

Fixes https://issues.redhat.com/browse/OCPBUGS-84324
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@fsgreco: This pull request references Jira Issue OCPBUGS-84324, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

  • Fix 404 links and redirects on README file
  • Fix outdated CI manifest reference to use main branch in README file

Jira bug: https://issues.redhat.com/browse/OCPBUGS-84324

Analysis / Root cause:
Some links in the project's main documentation files (README.md, CONTRIBUTING.md, STYLEGUIDE.md) are broken, redirecting, or outdated. These create a poor onboarding experience for new contributors and can lead to confusion when following setup instructions.

Additional info:
Redirects are not necessarily a 'not found' case per se, but they could eventually become invalid in the future; therefore, it is better to replace them with their current URLs if possible.

Reviewers and assignees:

Docs approver:
/assign @Leo6Leo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from jhadvig and rhamilto April 28, 2026 07:57
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fsgreco
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@fsgreco: This pull request references Jira Issue OCPBUGS-84324, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (5.0.0) matches configured target version for branch (5.0.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
Details

In response to this:

  • Fix 404 links and redirects on README file
  • Fix outdated CI manifest reference to use main branch in README file

Jira bug: https://issues.redhat.com/browse/OCPBUGS-84324

Analysis / Root cause:
Some links in the project's main documentation files (README.md, CONTRIBUTING.md, STYLEGUIDE.md) are broken, redirecting, or outdated. These create a poor onboarding experience for new contributors and can lead to confusion when following setup instructions.

Additional info:
Redirects are not necessarily a 'not found' case per se, but they could eventually become invalid in the future; therefore, it is better to replace them with their current URLs if possible.

Reviewers and assignees:

Docs approver:
/assign @Leo6Leo

Summary by CodeRabbit

  • Documentation
  • Updated contributing guide to reference current development branch workflow
  • Updated external resource links in documentation (Go modules, kubectl, CodeReady Containers)
  • Improved security of documentation references with HTTPS protocols

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9df48485-0d57-44ea-82c7-a29d1b063d20

📥 Commits

Reviewing files that changed from the base of the PR and between 78e8d00 and 3dbfb6e.

📒 Files selected for processing (1)
  • CONTRIBUTING.md
✅ Files skipped from review due to trivial changes (1)
  • CONTRIBUTING.md

Walkthrough

Updates to documentation: CONTRIBUTING.md switches default branch from master to main; README.md refreshes several external links and expands the jq usage note; STYLEGUIDE.md changes the BEM URL to HTTPS. All edits are documentation-only.

Changes

Cohort / File(s) Summary
Branching / Contribution
CONTRIBUTING.md
Change default base branch reference from master to main; backport workflow wording updated to reflect fixing in main first.
Repository README
README.md
Updated external links (gogo.dev, crc.dev for CodeReady Containers), narrowed kubectl link, expanded jq usage note to include scripts and tests, and updated CI presubmits reference from master to main.
Style guide
STYLEGUIDE.md
Replaced BEM reference URL with secure https://getbem.com/.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 11 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description provides analysis/root cause and additional context about broken/outdated links, but several required template sections are missing or incomplete: Solution description lacks detail, Screenshots section is absent, Test setup and Test cases are not provided, Browser conformance checkboxes are unchecked, and Reviewers/assignees section is incomplete. Fill in missing sections: add detailed solution description explaining specific link changes, test setup/cases for documentation verification, and complete reviewer assignments for proper triage and validation.
✅ Passed checks (11 passed)
Check name Status Explanation
Title check ✅ Passed The PR title clearly references the Jira issue (OCPBUGS-84324) and accurately summarizes the main objective: updating outdated documentation links and references, which aligns with changes across CONTRIBUTING.md, README.md, and STYLEGUIDE.md.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed This PR modifies only documentation files (CONTRIBUTING.md, README.md, STYLEGUIDE.md) with no test code or Ginkgo test definitions.
Test Structure And Quality ✅ Passed The custom check for Ginkgo test code quality is not applicable to this PR. This PR exclusively contains documentation updates to three markdown files, updating branch references and modernizing external documentation links. Since no test code modifications are present, the test structure and consistency requirements do not apply.
Microshift Test Compatibility ✅ Passed Pull request modifies only documentation files with no Ginkgo e2e tests added or modified, making the check not applicable and passing by default.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This PR only modifies documentation files (CONTRIBUTING.md, README.md, and STYLEGUIDE.md) and does not introduce any new Ginkgo e2e tests.
Topology-Aware Scheduling Compatibility ✅ Passed This PR modifies only documentation files (CONTRIBUTING.md, README.md, STYLEGUIDE.md) with no deployment manifests, operator code, or controller changes, making the topology-awareness check not applicable.
Ote Binary Stdout Contract ✅ Passed The OTE Binary Stdout Contract check only applies to process-level code. This PR contains only documentation changes with no code modifications, so the stdout contract cannot be violated.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR contains only documentation changes to markdown files; no Ginkgo e2e tests or test code modifications present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@CONTRIBUTING.md`:
- Line 16: Update the backporting section that still says "master branch first"
to use "main" for consistency; replace the sentence with the suggested wording:
"Typically, bugs are fixed in the main branch first then backported to the
appropriate release branches." Locate the paragraph in the CONTRIBUTING document
that describes backporting and change the word "master" to "main" and adjust the
sentence to match the provided phrasing.

In `@README.md`:
- Line 41: Replace the current CRC GitHub link and wording in README.md that
says "You can also use CodeReady Containers" to reference Red Hat's official
OpenShift Local documentation instead; update the text to mention "Red Hat
OpenShift Local" (or "Red Hat's OpenShift Local") and replace the URL with
https://access.redhat.com/documentation/en-us/red_hat_openshift_local/ so the
doc points to the official Red Hat product docs rather than the upstream crc
project.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 1a4a10df-1441-4a0d-a270-3eadc1c217d0

📥 Commits

Reviewing files that changed from the base of the PR and between 1298e98 and 78e8d00.

📒 Files selected for processing (3)
  • CONTRIBUTING.md
  • README.md
  • STYLEGUIDE.md
📜 Review details
🧰 Additional context used
🧠 Learnings (1)
📓 Common learnings
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:38.076Z
Learning: Make commits of logical units
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:38.076Z
Learning: Commit message subject line should describe what changed
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:38.076Z
Learning: Commit message body should describe why the change was made
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:38.076Z
Learning: Commits fixing Bugzilla bugs should include 'Bug <number>:' prefix in the first line and link to the bug in the commit body
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:38.076Z
Learning: Pull requests closing GitHub issues should include 'Closes #<issue_number>' in the pull request description
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:38.076Z
Learning: Fixes should be implemented in the master branch first, then backported to appropriate release branches (format: release-X.Y)
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: Dependencies should be pinned to an exact semver, sha, or git tag (eg, no ^)
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: Support the latest versions of Edge, Chrome, Safari, and Firefox browsers; do not support IE 11 and earlier
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: Use the console operator to install and manage the console in OpenShift 4.x clusters
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: The console proxies the Kubernetes API under /api/kubernetes and provides additional non-Kubernetes APIs
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: Frontend code lives in the frontend/ directory and uses node, yarn, and webpack to compile dependencies into bundles
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: Frontend bundles are not committed to git
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: Follow CONTRIBUTING.md for workflow and convention details
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:56:51.319Z
Learning: Follow STYLEGUIDE.md for file format and coding style guide
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:57:18.105Z
Learning: Use lowercase dash-separated names for all files (to avoid git issues with case-insensitive file systems). Exceptions are files with their own naming conventions (e.g., Dockerfile, Makefile, README)
Learnt from: CR
Repo: openshift/console

Timestamp: 2026-04-28T07:57:18.105Z
Learning: Plugin SDK Changes: Any updates to `console-dynamic-plugin-sdk` should aim to maintain backward compatibility. Use the `plugin-api-review` skill to vet changes for public API impact
🔇 Additional comments (5)
STYLEGUIDE.md (1)

36-36: LGTM – Protocol upgrade to HTTPS.

The update from HTTP to HTTPS is appropriate and aligns with modern security practices.

README.md (4)

19-21: LGTM – Modernized dependency documentation links.

The updates to Go and kubectl documentation URLs use current canonical endpoints. The expanded jq description with the GitHub code search link is helpful and appears accurate.


25-25: LGTM – Consistent Go documentation URL update.

This change aligns with the Go documentation modernization on line 19.


142-142: CRC documentation links verified as correct.

Both links to crc.dev/docs/networking/#setting-up-on-a-remote-server and crc.dev/docs/getting-started/#creating-openshift-preset resolve to valid sections in the CRC documentation and require no changes.


312-312: The CI manifest path is correct. The reference to https://github.com/openshift/release/blob/main/ci-operator/jobs/openshift/console/openshift-console-main-presubmits.yaml follows standard OpenShift CI operator conventions and aligns with the master→main branch migration. This is consistent with similar repos in the release repository.

Comment thread CONTRIBUTING.md
Comment thread README.md
[OpenShift Installer](https://mirror.openshift.com/pub/openshift-v4/clients/ocp/latest/). More information about installing OpenShift can be found at
<https://try.openshift.com/>.
You can also use [CodeReady Containers](https://github.com/code-ready/crc)
You can also use [CodeReady Containers](https://github.com/crc-org/crc)
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🌐 Web query:

Is crc.dev the official documentation site for CodeReady Containers?

💡 Result:

No, crc.dev is not the official documentation site for CodeReady Containers. crc.dev hosts the documentation for CRC (CodeReady Containers), which is the open-source upstream project. CodeReady Containers was Red Hat's branded distribution of CRC, now rebranded to Red Hat OpenShift Local. The official Red Hat documentation for Red Hat OpenShift Local (successor to CodeReady Containers) is hosted on access.redhat.com, such as https://access.redhat.com/documentation/en-us/red_hat_openshift_local/2.5/html-single/getting_started_guide/index.

Citations:


🏁 Script executed:

#!/bin/bash
# Get the README.md file around line 41 to see the context
cat -n README.md | head -60

Repository: openshift/console

Length of output: 3232


Clarify the documentation target—crc.dev documents the upstream open-source CRC project, not Red Hat's CodeReady Containers product.

The link should point to Red Hat's official OpenShift Local documentation (the successor to CodeReady Containers), not the upstream CRC repository. For consistency with this being an official OpenShift Console repository and the product context, use the Red Hat documentation rather than either the GitHub repo or upstream project docs.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@README.md` at line 41, Replace the current CRC GitHub link and wording in
README.md that says "You can also use CodeReady Containers" to reference Red
Hat's official OpenShift Local documentation instead; update the text to mention
"Red Hat OpenShift Local" (or "Red Hat's OpenShift Local") and replace the URL
with https://access.redhat.com/documentation/en-us/red_hat_openshift_local/ so
the doc points to the official Red Hat product docs rather than the upstream crc
project.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a valid point; however, as long as I understand OpenShift Local still relies on CRC under the hood (and the installation guide on developers.redhat.com is not publicly accessible, unlike the CRC one), what do you think, @Leo6Leo?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like the humans are having a chat. I'll hop back into my burrow for now. If you need me again, just tag @coderabbitai in a new comment, and I'll come hopping out!

@Leo6Leo
Copy link
Copy Markdown
Contributor

Leo6Leo commented Apr 28, 2026

@fsgreco Coderabbit's comment makes sense to me, will take a look again after you've fixed it

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 29, 2026

@fsgreco: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants