Skip to content

ROSA-745: boilerplate-update and enable MintMaker gomod#487

Open
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod
Open

ROSA-745: boilerplate-update and enable MintMaker gomod#487
MitaliBhalla wants to merge 1 commit into
openshift:masterfrom
MitaliBhalla:rosa-745-mintmaker-gomod

Conversation

@MitaliBhalla

@MitaliBhalla MitaliBhalla commented Jun 12, 2026

Copy link
Copy Markdown

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Summary by CodeRabbit

  • Chores
    • Enhanced automated dependency management: enabled Tekton and Go module managers and improved update tracking.
    • Updated dependency automation scheduling and labels for Docker updates, and standardized boilerplate-ignore references.
    • Adjusted project ownership aliases to reflect current team membership (removed one alias).

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 0766ab6e-f365-421a-aa27-159ec471106f

📥 Commits

Reviewing files that changed from the base of the PR and between a4cf641 and 098d4a0.

⛔ Files ignored due to path filters (19)
  • boilerplate/_data/last-boilerplate-commit is excluded by !boilerplate/**
  • boilerplate/_lib/subscriber-propose-update is excluded by !boilerplate/**
  • boilerplate/openshift/golang-osd-operator/OWNERS_ALIASES is excluded by !boilerplate/**
  • deploy_pko/.test-fixtures/default/Cleanup-OLM-Job.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/default/ClusterRole-certman-operator.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/default/ClusterRoleBinding-certman-operator.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/default/CustomResourceDefinition-certificaterequests.certman.managed.openshift.io.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/default/Deployment-certman-operator.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/default/Role-prometheus-k8s.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/default/RoleBinding-prometheus-k8s.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/default/ServiceAccount-certman-operator.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/Cleanup-OLM-Job.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/ClusterRole-certman-operator.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/ClusterRoleBinding-certman-operator.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/CustomResourceDefinition-certificaterequests.certman.managed.openshift.io.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/Deployment-certman-operator.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/Role-prometheus-k8s.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/RoleBinding-prometheus-k8s.yaml is excluded by !**/.test-fixtures/**
  • deploy_pko/.test-fixtures/fedramp/ServiceAccount-certman-operator.yaml is excluded by !**/.test-fixtures/**
📒 Files selected for processing (3)
  • .github/dependabot.yml
  • .github/renovate.json
  • OWNERS_ALIASES
💤 Files with no reviewable changes (1)
  • OWNERS_ALIASES
✅ Files skipped from review due to trivial changes (1)
  • .github/renovate.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/dependabot.yml

Walkthrough

Repository infrastructure updated with three independent configuration changes: Dependabot configuration expanded with boilerplate-managed markers and updated labels/schedule, Renovate configuration enables tekton and gomod managers, and an alias removed from OWNERS_ALIASES.

Changes

Configuration and team management updates

Layer / File(s) Summary
Dependabot boilerplate management configuration
.github/dependabot.yml
Dependabot Docker update configuration for /build wrapped in boilerplate-managed; labels extended to include lgtm and approved; ignored boilerplate dependency changed to redhat-services-prod/openshift/boilerplate; schedule made explicit with day: monday, time: 03:00, timezone: UTC.
Renovate tooling managers enablement
.github/renovate.json
Adds enabledManagers array with tekton and gomod.
Team membership update
OWNERS_ALIASES
Removed devppratik from srep-functional-team-hulk aliases.

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: a boilerplate update and enabling MintMaker gomod support via renovate configuration, which directly align with the PR's stated objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Scanned Ginkgo titles in test/e2e (certman_operator_tests.go); all It/Describe titles are static string literals with no fmt.Sprintf/time/UUID/random suffix patterns.
Test Structure And Quality ✅ Passed PR #487 only changes .github/ and boilerplate//* (no *_test.go or Ginkgo specs in the PR files), so the Ginkgo test-quality check is not applicable.
Microshift Test Compatibility ✅ Passed PR #487 only updates Dependabot/Renovate config and boilerplate/OWNERS files; no new Ginkgo e2e test code was added to evaluate for MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Reviewed e2e Ginkgo tests in test/e2e/certman_operator_tests.go; no SNO-protection markers and no multi-node/HA assumptions detected (no node/topology scheduling logic).
Topology-Aware Scheduling Compatibility ✅ Passed Scanned files modified in this PR for scheduling-constraint keywords (affinity/anti-affinity, topologySpreadConstraints, nodeSelector/node-role labels, PDB, etc.); none found—e.g., deploy/operator....
Ote Binary Stdout Contract ✅ Passed OTE suite code is under test/e2e/osde2e; runner_test.go’s TestCertmanOperator (RunSpecs setup) has no fmt.Print/os.Stdout. fmt.Printf/Println are only inside It() specs.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR #487 only changes dependabot.yml, renovate.json, OWNERS_ALIASES, and boilerplate metadata—no Go/Ginkgo e2e test files added to scan for IPv4/external connectivity assumptions.
No-Weak-Crypto ✅ Passed Checked .github/dependabot.yml, .github/renovate.json, and OWNERS_ALIASES for MD5/SHA1/DES/RC4/3DES/Blowfish/ECB tokens; none found. Repo-wide scans also found no crypto/md5/sha1/des/rc4/blowfish u...
Container-Privileges ✅ Passed Scanned repo k8s/YAML for hostPID/hostNetwork/hostIPC, SYS_ADMIN, privileged:true, allowPrivilegeEscalation:true, runAsUser:0; none found. PR files are config-only (.github/..., OWNERS_ALIASES).
No-Sensitive-Data-In-Logs ✅ Passed Inspected .github/dependabot.yml, .github/renovate.json, and OWNERS_ALIASES; keyword scans for tokens/passwords/secrets/PII found none, and no logging code changes are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 12, 2026

Copy link
Copy Markdown

@MitaliBhalla: This pull request references ROSA-745 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the initiative to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • make boilerplate-update (includes boilerplate #748 dependabot template)
  • .github/renovate.jsonenabledManagers: [tekton, gomod] for MintMaker gomod PRs

Test plan

  • CI green

Jira: ROSA-745

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from charlesgong and hbhushan3 June 12, 2026 08:17
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MitaliBhalla
Once this PR has been reviewed and has the lgtm label, please assign theautoroboto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.14%. Comparing base (09ed286) to head (098d4a0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #487   +/-   ##
=======================================
  Coverage   57.14%   57.14%           
=======================================
  Files          29       29           
  Lines        2170     2170           
=======================================
  Hits         1240     1240           
  Misses        812      812           
  Partials      118      118           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Run make boilerplate-update and set renovate enabledManagers to tekton/gomod.

Co-authored-by: Cursor <cursoragent@cursor.com>
@MitaliBhalla MitaliBhalla force-pushed the rosa-745-mintmaker-gomod branch from a4cf641 to 098d4a0 Compare June 12, 2026 08:52
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@MitaliBhalla: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants