Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Hello @jubittajohn! Some important instructions when contributing to openshift/api: |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (293)
📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughThis pull request upgrades the Go toolchain from version 1.25.0 to 1.26.0 across the project. The changes include updates to CI/CD configuration files, specifically the build root image name, namespace, and tag in 🚥 Pre-merge checks | ✅ 9 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (9 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (1)
Dockerfile.ocp (1)
1-1: Consider specifying a non-root USER for improved security.The static analysis tool flagged that the Dockerfile does not specify a non-root USER. While this appears to be a pre-existing condition not introduced by this PR, running containers as root increases the attack surface if a container escape vulnerability is exploited. Consider adding a
USERdirective with a non-root user.As per static analysis tool Trivy rule DS-0002.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile.ocp` at line 1, The Dockerfile currently uses the base image declared by the FROM line and does not set a non-root user; add a non-root user and switch to it by creating a dedicated user/group during the build (e.g., via a RUN that creates a user and chowns necessary directories) and then add a USER directive to run the image as that non-root user; update any build/copy/chown steps so files the process needs are owned by that user and ensure any build-stage artifacts remain accessible to the runtime user (reference the Dockerfile's FROM image and add the user creation and USER directives in the builder/runtime stages as appropriate).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile.ocp`:
- Line 1: The Dockerfile's builder stage uses a personal Quay image (the FROM
line with "AS builder") which must be reverted to the official OpenShift builder
image; replace the current base image reference with the official OpenShift
registry image (e.g., registry.ci.openshift.org/ocp/builder:<appropriate-tag>)
so the FROM line in the builder stage uses the trusted official registry and tag
that matches your OpenShift/Golang version and CI policy.
In `@tools/go.mod`:
- Around line 35-38: The go.mod replace block replaces
github.com/openshift/crd-schema-checker and sigs.k8s.io/controller-tools with
personal forks (the replace(...) block) which must be removed; revert these
temporary replace directives to the official module paths/versions (or replace
them with approved, upstream-release module versions or a vetted internal
mirror) and remove references to the jubittajohn forks (commit d28fb149918a and
the controller-tools carry patch fork) so builds use upstream artifacts subject
to dependency review and reproducible builds.
---
Nitpick comments:
In `@Dockerfile.ocp`:
- Line 1: The Dockerfile currently uses the base image declared by the FROM line
and does not set a non-root user; add a non-root user and switch to it by
creating a dedicated user/group during the build (e.g., via a RUN that creates a
user and chowns necessary directories) and then add a USER directive to run the
image as that non-root user; update any build/copy/chown steps so files the
process needs are owned by that user and ensure any build-stage artifacts remain
accessible to the runtime user (reference the Dockerfile's FROM image and add
the user creation and USER directives in the builder/runtime stages as
appropriate).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 73aaca3b-672f-4cab-9d44-e8d389a5f31b
⛔ Files ignored due to path filters (294)
go.sumis excluded by!**/*.sumopenapi/generated_openapi/zz_generated.openapi.gois excluded by!openapi/**,!**/zz_generated*tools/go.sumis excluded by!**/*.sumtools/vendor/cel.dev/expr/BUILD.bazelis excluded by!**/vendor/**tools/vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**tools/vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cloud.google.com/go/compute/metadata/CHANGES.mdis excluded by!**/vendor/**tools/vendor/cloud.google.com/go/compute/metadata/metadata.gois excluded by!**/vendor/**tools/vendor/cloud.google.com/go/compute/metadata/retry.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/context.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/exponential.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/retry.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/tries.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/.gitignoreis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/CHANGELOG.mdis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/LICENSEis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/README.mdis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/backoff.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/error.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/exponential.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/retry.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/ticker.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/timer.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/sensitive.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/sensitive.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/.travis.ymlis excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/CHANGES.mdis excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/README.mdis excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/curly.gois excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/custom_verb.gois excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/doc.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/clusters.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/accesslog/v3/accesslog.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/accesslog/v3/accesslog.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/cluster/v3/cluster.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/matcher/v3/matcher.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/matcher/v3/matcher.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/matcher/v3/matcher_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/address.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/address.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/address_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/base.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/base.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/config_source.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/health_check.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/substitution_format_string.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint_components.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint_components_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/load_report.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/overload/v3/overload.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3/rbac.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3/rbac.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3/rbac_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/tap/v3/common.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/tap/v3/common.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/tap/v3/common_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/opentelemetry.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/opentelemetry.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/opentelemetry_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/data/accesslog/v3/accesslog.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3/cluster.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3/cluster.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3/cluster_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/router/v3/router.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/common.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/common.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/common_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/secret.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/secret.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/secret_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/service/discovery/v3/discovery.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/http/v3/cookie.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/http/v3/cookie.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/http/v3/cookie_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3/metadata.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3/string.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/metadata/v3/metadata.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/protoc-gen-validate/validate/BUILDis excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/CHANGELOG.mdis excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/README.mdis excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/crypter.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/jwe.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/jwk.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/jws.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/shared.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/signing.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/symmetric.gois excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/BUILD.bazelis excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/context.gois excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/marshal_jsonpb.gois excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/decode.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/expfmt.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/fuzz.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/openmetrics_create.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/text_create.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/text_parse.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/.golangci.ymlis excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/Makefileis excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/Makefile.commonis excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/arp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/buddyinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cmdline.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_armx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_loong64.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_mipsx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_others.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_ppcx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_riscvx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_s390x.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_x86.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/crypto.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/doc.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fs_statfs_notype.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fs_statfs_type.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fscache.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/fs/fs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/parse.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/readfile.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/sysreadfile.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/sysreadfile_compat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/valueparser.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/ipvs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/kernel_hung.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/kernel_random.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/loadavg.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/mdstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/meminfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/mountinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/mountstats.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_conntrackstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_dev.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_dev_snmp6.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_ip_socket.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_protocols.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_route.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_sockstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_softnet.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_tcp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_tls_stat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_udp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_unix.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_wireless.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_xfrm.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/netstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/nfnetlink_queue.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_cgroup.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_cgroups.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_environ.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_fdinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_interrupts.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_io.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_limits.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_maps.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_netstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_ns.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_psi.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_smaps.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_snmp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_snmp6.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_stat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_statm.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_status.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_sys.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/schedstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/slab.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/softirqs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/stat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/swaps.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/thread.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/vm.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/zoneinfo.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/jwtbundle/bundle.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/jwtbundle/set.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/spiffebundle/bundle.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/spiffebundle/set.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/x509bundle/bundle.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/x509bundle/set.gois excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/.gitignoreis excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/AUTHORSis excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/LICENSEis excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/README.mdis excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/errs.gois excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/group.gois excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/is_go1.20.gois excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/is_go_other.gois excluded by!**/vendor/**
📒 Files selected for processing (6)
.ci-operator.yamlDockerfile.ocpgo.modinstall.gotools/codegen/pkg/deepcopy/deepcopy.gotools/go.mod
💤 Files with no reviewable changes (2)
- tools/codegen/pkg/deepcopy/deepcopy.go
- install.go
| @@ -1,4 +1,4 @@ | |||
| FROM registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.25-openshift-4.22 AS builder | |||
| FROM quay.io/jacobsee/openshift-build:rhel-9-golang-1.25 AS builder | |||
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the official OpenShift builder image exists
echo "=== Checking official OpenShift builder images ==="
echo "Personal registry found: quay.io/jacobsee/openshift-build:rhel-9-golang-1.25"
echo "Expected official registry: registry.ci.openshift.org/ocp/builder:*"
echo ""
echo "This appears to be testing infrastructure that should be reverted to official images."Repository: openshift/api
Length of output: 339
🏁 Script executed:
# Check if Dockerfile.ocp exists and examine its history
git ls-files | grep -i dockerfileRepository: openshift/api
Length of output: 799
🏁 Script executed:
# Look for the .ci-operator.yaml file
find . -name ".ci-operator.yaml" -o -name "ci-operator.yaml" 2>/dev/null | head -20Repository: openshift/api
Length of output: 76
🏁 Script executed:
# Search for references to this dockerfile or quay.io/jacobsee
rg -i "jacobsee|quay\.io.*openshift-build" --type yaml --type txtRepository: openshift/api
Length of output: 39
🏁 Script executed:
cat -n Dockerfile.ocpRepository: openshift/api
Length of output: 1147
🏁 Script executed:
cat -n .ci-operator.yamlRepository: openshift/api
Length of output: 171
🏁 Script executed:
# Check git history of Dockerfile.ocp
git log --oneline Dockerfile.ocp | head -20Repository: openshift/api
Length of output: 88
🏁 Script executed:
# Get full git history with more details
git log --all --pretty=format:"%H %s" -- Dockerfile.ocp | head -20Repository: openshift/api
Length of output: 1704
🏁 Script executed:
# Check the actual changes in recent commits
git show HEAD:Dockerfile.ocp 2>/dev/null || echo "File not in HEAD"Repository: openshift/api
Length of output: 986
🏁 Script executed:
# Check git status - is this file modified locally?
git status Dockerfile.ocpRepository: openshift/api
Length of output: 122
🏁 Script executed:
# Look for any recent changes to Dockerfile.ocp
git diff HEAD~5..HEAD -- Dockerfile.ocp 2>/dev/null || echo "Cannot show diff"Repository: openshift/api
Length of output: 73
🏁 Script executed:
# Show the specific commit that mentions "update builder images"
git show c63fe74a:Dockerfile.ocp 2>/dev/null | head -20Repository: openshift/api
Length of output: 916
🏁 Script executed:
# Show the commit message and details
git show --stat c63fe74aRepository: openshift/api
Length of output: 346
🏁 Script executed:
# Check what was in the version before the personal registry was introduced
git show c63fe74a~1:Dockerfile.ocp 2>/dev/null | head -20Repository: openshift/api
Length of output: 916
Base image uses personal Quay.io registry instead of official OpenShift registry.
The builder base image has been changed from the official OpenShift registry (registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.24-openshift-4.22) to a personal Quay.io repository (quay.io/jacobsee/openshift-build:rhel-9-golang-1.25). This introduces critical risks:
- Supply chain security: Personal registries bypass OpenShift's image scanning, signing, and security controls
- Build reproducibility: Downstream consumers cannot reliably build if the personal image is unavailable
- Production compliance: Using unofficial base images violates container security best practices
Revert the builder stage to use the official OpenShift registry before merging.
🧰 Tools
🪛 Trivy (0.69.3)
[error] 1-1: Image user should not be 'root'
Specify at least 1 USER command in Dockerfile with non-root user as argument
Rule: DS-0002
(IaC/Dockerfile)
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@Dockerfile.ocp` at line 1, The Dockerfile's builder stage uses a personal
Quay image (the FROM line with "AS builder") which must be reverted to the
official OpenShift builder image; replace the current base image reference with
the official OpenShift registry image (e.g.,
registry.ci.openshift.org/ocp/builder:<appropriate-tag>) so the FROM line in the
builder stage uses the trusted official registry and tag that matches your
OpenShift/Golang version and CI policy.
| replace ( | ||
| github.com/openshift/crd-schema-checker => github.com/jubittajohn/crd-schema-checker v0.0.0-20260416212918-d28fb149918a | ||
| sigs.k8s.io/controller-tools => github.com/jubittajohn/kubernetes-sigs-controller-tools v0.12.1-0.20260416174844-7bb81bc749fd | ||
| ) |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify if these forks contain changes not available in upstream
echo "=== Checking jubittajohn/crd-schema-checker fork ==="
echo "Fork commit: d28fb149918a"
gh api repos/jubittajohn/crd-schema-checker/commits/d28fb149918a --jq '.commit.message' 2>/dev/null || echo "Cannot access fork"
echo ""
echo "=== Checking jubittajohn/kubernetes-sigs-controller-tools fork ==="
echo "Fork commit: 7bb81bc749fd"
gh api repos/jubittajohn/kubernetes-sigs-controller-tools/commits/7bb81bc749fd --jq '.commit.message' 2>/dev/null || echo "Cannot access fork"
echo ""
echo "=== Official sigs.k8s.io/controller-tools latest ==="
gh api repos/kubernetes-sigs/controller-tools/commits/main --jq '.commit.message' 2>/dev/null || echo "Cannot access upstream"Repository: openshift/api
Length of output: 1089
CRITICAL: Replace directives reference personal forks with temporary and carry patches.
The replace block redirects both github.com/openshift/crd-schema-checker and sigs.k8s.io/controller-tools to personal GitHub repositories under the jubittajohn account. These must not be merged to master because:
- The
crd-schema-checkerfork is explicitly marked as temporary: commitd28fb149918astates "Bump to rhel-9-release-golang-1.26-openshift-5.0(temp using a local build image)" - The
controller-toolsfork contains upstream carry patches (UPSTREAM: <carry>:) not present in the official repository, indicating unreleased development code - This creates supply chain risks (personal repos can be deleted or modified)
- Breaks reproducible builds for downstream consumers
- Bypasses official dependency review and security processes
These replace directives are temporary testing infrastructure that must be reverted before merging.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tools/go.mod` around lines 35 - 38, The go.mod replace block replaces
github.com/openshift/crd-schema-checker and sigs.k8s.io/controller-tools with
personal forks (the replace(...) block) which must be removed; revert these
temporary replace directives to the official module paths/versions (or replace
them with approved, upstream-release module versions or a vetted internal
mirror) and remove references to the jubittajohn forks (commit d28fb149918a and
the controller-tools carry patch fork) so builds use upstream artifacts subject
to dependency review and reproducible builds.
|
@jubittajohn: This pull request references OCPSTRAT-3036 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Signed-off-by: jubittajohn <jujohn@redhat.com>
Signed-off-by: jubittajohn <jujohn@redhat.com>
…ng v1alpha1 APIs Signed-off-by: jubittajohn <jujohn@redhat.com>
Signed-off-by: jubittajohn <jujohn@redhat.com>
Signed-off-by: jubittajohn <jujohn@redhat.com>
…Dirs from deepcopy-gen args
Signed-off-by: jubittajohn <jujohn@redhat.com>
Signed-off-by: jubittajohn <jujohn@redhat.com>
cf064e8 to
f83e4ca
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
Dockerfile.ocp (1)
1-1:⚠️ Potential issue | 🟠 MajorPersonal registry issue remains unresolved; Go version mismatch detected.
Two concerns with this builder image:
Personal registry (duplicate): The builder image still uses
quay.io/jacobsee/openshift-buildinstead of the official OpenShift registry. This critical supply-chain security issue was already flagged in previous reviews and must be resolved before merging.Go version inconsistency: The Dockerfile references
rhel-9-golang-1.25, but the PR summary states that Go was bumped from 1.25.0 to 1.26.0. This mismatch suggests either:
- The Dockerfile should use a golang-1.26 image, or
- The PR summary is incorrect about the Go version update
Run the following script to verify the intended Go version and available images:
#!/bin/bash # Description: Verify Go version in go.mod files and check if golang-1.26 builder images exist echo "=== Checking Go version in go.mod files ===" fd -e mod -x grep -H "^go " {} echo "" echo "=== Checking if official OpenShift builder images with golang-1.26 exist ===" echo "Expected pattern: registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.26-*" echo "" echo "Note: The personal registry image should be replaced with the official registry."If Go 1.26 is confirmed, the builder image should reference
golang-1.26instead ofgolang-1.25.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile.ocp` at line 1, Replace the personal quay.io image in the Dockerfile.ocp FROM line (currently using quay.io/jacobsee/openshift-build:rhel-9-golang-1.25) with the official OpenShift builder registry image and ensure the Go minor version matches the repo intent; run the provided verification script to check go.mod go version and existence of an official registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.26-* image, then update the FROM tag to rhel-9-golang-1.26 if Go 1.26 is confirmed, otherwise correct the PR summary to reflect 1.25; ensure the change targets the FROM instruction in Dockerfile.ocp (the builder image reference).
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@Dockerfile.ocp`:
- Line 1: Replace the personal quay.io image in the Dockerfile.ocp FROM line
(currently using quay.io/jacobsee/openshift-build:rhel-9-golang-1.25) with the
official OpenShift builder registry image and ensure the Go minor version
matches the repo intent; run the provided verification script to check go.mod go
version and existence of an official
registry.ci.openshift.org/ocp/builder:rhel-9-golang-1.26-* image, then update
the FROM tag to rhel-9-golang-1.26 if Go 1.26 is confirmed, otherwise correct
the PR summary to reflect 1.25; ensure the change targets the FROM instruction
in Dockerfile.ocp (the builder image reference).
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 37e7ab44-512d-4ae0-8dae-109135f3aed1
⛔ Files ignored due to path filters (287)
go.sumis excluded by!**/*.sumopenapi/generated_openapi/zz_generated.openapi.gois excluded by!openapi/**,!**/zz_generated*tools/go.sumis excluded by!**/*.sumtools/vendor/cel.dev/expr/BUILD.bazelis excluded by!**/vendor/**tools/vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**tools/vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/cloud.google.com/go/compute/metadata/CHANGES.mdis excluded by!**/vendor/**tools/vendor/cloud.google.com/go/compute/metadata/metadata.gois excluded by!**/vendor/**tools/vendor/cloud.google.com/go/compute/metadata/retry.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/context.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/exponential.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/retry.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v4/tries.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/.gitignoreis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/CHANGELOG.mdis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/LICENSEis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/README.mdis excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/backoff.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/error.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/exponential.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/retry.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/ticker.gois excluded by!**/vendor/**tools/vendor/github.com/cenkalti/backoff/v5/timer.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/sensitive.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/sensitive.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/.travis.ymlis excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/CHANGES.mdis excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/README.mdis excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/curly.gois excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/custom_verb.gois excluded by!**/vendor/**tools/vendor/github.com/emicklei/go-restful/v3/doc.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/admin/v3/clusters.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/accesslog/v3/accesslog.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/accesslog/v3/accesslog.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/cluster/v3/cluster.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/matcher/v3/matcher.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/matcher/v3/matcher.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/matcher/v3/matcher_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/address.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/address.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/address_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/base.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/base.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/config_source.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/health_check.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/substitution_format_string.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint_components.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/endpoint_components_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/load_report.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/overload/v3/overload.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3/rbac.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3/rbac.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/rbac/v3/rbac_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/tap/v3/common.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/tap/v3/common.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/tap/v3/common_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/opentelemetry.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/opentelemetry.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/opentelemetry_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/data/accesslog/v3/accesslog.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3/cluster.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3/cluster.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/clusters/aggregate/v3/cluster_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/http/router/v3/router.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/common.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/common.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/common_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/secret.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/secret.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/transport_sockets/tls/v3/secret_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/service/discovery/v3/discovery.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/http/v3/cookie.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/http/v3/cookie.pb.validate.gois excluded by!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/http/v3/cookie_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3/metadata.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3/string.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/go-control-plane/envoy/type/metadata/v3/metadata.pb.gois excluded by!**/*.pb.go,!**/vendor/**tools/vendor/github.com/envoyproxy/protoc-gen-validate/validate/BUILDis excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/CHANGELOG.mdis excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/README.mdis excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/crypter.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/jwe.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/jwk.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/jws.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/shared.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/signing.gois excluded by!**/vendor/**tools/vendor/github.com/go-jose/go-jose/v4/symmetric.gois excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/BUILD.bazelis excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/context.gois excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/marshal_jsonpb.gois excluded by!**/vendor/**tools/vendor/github.com/grpc-ecosystem/grpc-gateway/v2/runtime/mux.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/decode.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/expfmt.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/fuzz.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/openmetrics_create.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/text_create.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/common/expfmt/text_parse.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/.golangci.ymlis excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/Makefileis excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/Makefile.commonis excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/arp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/buddyinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cmdline.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_armx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_loong64.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_mipsx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_others.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_ppcx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_riscvx.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_s390x.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/cpuinfo_x86.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/crypto.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/doc.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fs_statfs_notype.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fs_statfs_type.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/fscache.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/fs/fs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/parse.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/readfile.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/sysreadfile.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/sysreadfile_compat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/internal/util/valueparser.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/ipvs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/kernel_hung.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/kernel_random.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/loadavg.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/mdstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/meminfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/mountinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/mountstats.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_conntrackstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_dev.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_dev_snmp6.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_ip_socket.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_protocols.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_route.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_sockstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_softnet.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_tcp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_tls_stat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_udp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_unix.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_wireless.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/net_xfrm.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/netstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/nfnetlink_queue.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_cgroup.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_cgroups.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_environ.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_fdinfo.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_interrupts.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_io.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_limits.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_maps.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_netstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_ns.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_psi.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_smaps.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_snmp.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_snmp6.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_stat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_statm.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_status.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/proc_sys.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/schedstat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/slab.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/softirqs.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/stat.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/swaps.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/thread.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/vm.gois excluded by!**/vendor/**tools/vendor/github.com/prometheus/procfs/zoneinfo.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/jwtbundle/bundle.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/jwtbundle/set.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/spiffebundle/bundle.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/spiffebundle/set.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/x509bundle/bundle.gois excluded by!**/vendor/**tools/vendor/github.com/spiffe/go-spiffe/v2/bundle/x509bundle/set.gois excluded by!**/vendor/**tools/vendor/github.com/zeebo/errs/.gitignoreis excluded by!**/vendor/**
📒 Files selected for processing (6)
.ci-operator.yamlDockerfile.ocpgo.modinstall.gotools/codegen/pkg/deepcopy/deepcopy.gotools/go.mod
💤 Files with no reviewable changes (2)
- tools/codegen/pkg/deepcopy/deepcopy.go
- install.go
✅ Files skipped from review due to trivial changes (1)
- .ci-operator.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
- go.mod
- tools/go.mod
Signed-off-by: jubittajohn <jujohn@redhat.com>
Signed-off-by: jubittajohn <jujohn@redhat.com>
|
@jubittajohn: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary