CORS-4435: GCP Sovereign Cloud Feature Gate#2810
CORS-4435: GCP Sovereign Cloud Feature Gate#2810barbacbd wants to merge 1 commit intoopenshift:masterfrom
Conversation
- Name: GCPSovereignCloudInstall (with "Install" prefix as required for installer feature gates) - Location: features/features.go:875-881 - Jira Component: "Installer" - Contact: barbacbd - Enhancement PR: openshift/enhancements#1977 - Enabled in: TechPreviewNoUpgrade and DevPreviewNoUpgrade Generated Files Updated: - features.md - Documentation showing the feature gate is enabled in TechPreview and DevPreview - Multiple feature gate manifest files for both Hypershift and SelfManagedHA cluster profiles The feature gate follows the same pattern as the existing FeatureGateAWSEuropeanSovereignCloudInstall for AWS sovereign cloud support, making it consistent with similar installer features. Authored by claude and reviewed by @barbacbd
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@barbacbd: This pull request references CORS-4435 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @barbacbd! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (10)
📝 WalkthroughWalkthroughThis pull request introduces a new feature gate named 🚥 Pre-merge checks | ✅ 10✅ Passed checks (10 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@barbacbd: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Generated Files Updated:
The feature gate follows the same pattern as the existing FeatureGateAWSEuropeanSovereignCloudInstall
for AWS sovereign cloud support, making it consistent with similar installer features.
Authored by claude and reviewed by @barbacbd