Skip to content

CORS-4435: GCP Sovereign Cloud Feature Gate#2810

Open
barbacbd wants to merge 1 commit intoopenshift:masterfrom
barbacbd:CORS-4435
Open

CORS-4435: GCP Sovereign Cloud Feature Gate#2810
barbacbd wants to merge 1 commit intoopenshift:masterfrom
barbacbd:CORS-4435

Conversation

@barbacbd
Copy link
Copy Markdown
Contributor

Generated Files Updated:

  • features.md - Documentation showing the feature gate is enabled in TechPreview and DevPreview
  • Multiple feature gate manifest files for both Hypershift and SelfManagedHA cluster profiles

The feature gate follows the same pattern as the existing FeatureGateAWSEuropeanSovereignCloudInstall
for AWS sovereign cloud support, making it consistent with similar installer features.

Authored by claude and reviewed by @barbacbd

  - Name: GCPSovereignCloudInstall (with "Install" prefix as required for installer feature gates)
  - Location: features/features.go:875-881
  - Jira Component: "Installer"
  - Contact: barbacbd
  - Enhancement PR: openshift/enhancements#1977
  - Enabled in: TechPreviewNoUpgrade and DevPreviewNoUpgrade

  Generated Files Updated:
  - features.md - Documentation showing the feature gate is enabled in TechPreview and DevPreview
  - Multiple feature gate manifest files for both Hypershift and SelfManagedHA cluster profiles

  The feature gate follows the same pattern as the existing FeatureGateAWSEuropeanSovereignCloudInstall
  for AWS sovereign cloud support, making it consistent with similar installer features.

Authored by claude and reviewed by @barbacbd
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 17, 2026
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 17, 2026

@barbacbd: This pull request references CORS-4435 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Generated Files Updated:

  • features.md - Documentation showing the feature gate is enabled in TechPreview and DevPreview
  • Multiple feature gate manifest files for both Hypershift and SelfManagedHA cluster profiles

The feature gate follows the same pattern as the existing FeatureGateAWSEuropeanSovereignCloudInstall
for AWS sovereign cloud support, making it consistent with similar installer features.

Authored by claude and reviewed by @barbacbd

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

Hello @barbacbd! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3198f164-b6ef-48c3-9a30-95821f0458c6

📥 Commits

Reviewing files that changed from the base of the PR and between f9587f6 and efad4e6.

📒 Files selected for processing (10)
  • features.md
  • features/features.go
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
  • payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

📝 Walkthrough

Walkthrough

This pull request introduces a new feature gate named GCPSovereignCloudInstall across the OpenShift codebase. The feature gate definition is added to features/features.go with configuration for the Installer component, enabled in technology preview and development preview modes. Corresponding entries are added to eight FeatureGate manifest files across different deployment profiles (Hypershift and SelfManagedHA): the feature is enabled in DevPreviewNoUpgrade and TechPreviewNoUpgrade profiles, while disabled in Default and OKD profiles. Documentation is updated in features.md to reflect the new feature gate's enabled status.

🚥 Pre-merge checks | ✅ 10
✅ Passed checks (10 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: adding a GCP Sovereign Cloud Feature Gate (CORS-4435).
Description check ✅ Passed The description directly relates to the changeset, providing context about the new feature gate including its location, configuration, and consistency with similar features.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Stable And Deterministic Test Names ✅ Passed This pull request does not modify any test files and does not introduce new Ginkgo test names. Changes are limited to feature gate definitions and documentation.
Test Structure And Quality ✅ Passed PR contains no Ginkgo test code modifications, only feature gate definitions and documentation updates.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added. Changes are limited to feature gate definitions and documentation.
Single Node Openshift (Sno) Test Compatibility ✅ Passed This pull request does not add any new Ginkgo e2e tests. The changes consist solely of adding a new feature gate definition and updating manifest files. No test files or Ginkgo test patterns were found in the modified source files.
Topology-Aware Scheduling Compatibility ✅ Passed PR introduces only feature gate declarations and documentation without scheduling constraints, pod affinity rules, or topology-specific assumptions.
Ote Binary Stdout Contract ✅ Passed PR adds GCPSovereignCloudInstall feature gate through declarative configuration only, with no stdout-writing code in process-level functions.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR does not add any Ginkgo e2e tests. Changes are limited to feature gate definitions, documentation, and YAML configuration manifests.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented


Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 17, 2026

@barbacbd: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants