SRVKP-12189: Remove TektonHub integration from pipelines task catalog and quick search#1095
Conversation
|
/agentic_review |
This comment was marked as outdated.
This comment was marked as outdated.
e08e53b to
ba8f317
Compare
|
/agentic_describe |
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit ba8f317 |
PR Summary by QodoRemove TektonHub integration from pipelines task catalog and quick search Description
Diagram
High-Level Assessment
Files changed (20)
|
|
@anwesha-palit-redhat: This pull request references SRVKP-12189 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ba8f317 to
0ac3fd6
Compare
4b5a75f to
a478756
Compare
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit a478756 |
a478756 to
b56b7f4
Compare
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit 0fe6ee3 |
0fe6ee3 to
c120759
Compare
|
/agentic_review |
|
Code review by qodo was updated up to the latest commit c120759 |
| item.content_url; | ||
| selectedItem.tags = item.keywords; | ||
| if (mounted) { | ||
| selectedItem.attributes.versions = item.available_versions; |
There was a problem hiding this comment.
moved these inside if block to prevent stale updates
selectedItem.attributes.versions = item.available_versions; selectedItem.attributes.selectedVersionContentUrl = item.content_url; selectedItem.tags = item.keywords;
and selectedVersionForContentUrl to track which version the cached URL belongs to - this is from Qodo Reviews
c120759 to
4ff446f
Compare
|
/agentic-review |
4ff446f to
5c01cea
Compare
|
/test e2e |
|
PR-Agent: could not find a component named |
|
verified with PR image in openshift cluster Screen.Recording.2026-06-19.at.6.44.20.PM-1080p.mov |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anwesha-palit-redhat, arvindk-softwaredev The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c439824
into
openshift-pipelines:main
|
/cherry-pick release-v1.22.x |
|
@anwesha-palit-redhat: new pull request created: #1137 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary
Removes TektonHub from the pipelines console plugin and consolidates task catalog behavior on ArtifactHub. Also hardens ArtifactHub quick search install/update flows, fixes
enable-devconsole-integrationgating, and prevents installing/updating the wrong YAML when the user switches versions.Changes
TektonHub removal
PipelineQuickSearch,PipelineQuickSearchDetails, and related utils.ArtifactHub quick search hardening
PipelineQuickSearch, fetch ArtifactHub task details on-demand whenselectedVersionContentUrlis missing before create/update.selectedVersionForContentUrlalongside the cached URL;getSelectedVersionUrlreturnsnullwhen the cached URL does not match the requested version, forcing a refetch for the correct YAML. >>> this is fromQodoPipelineQuickSearchDetails.createArtifactHubTask/updateArtifactHubTask.PipelineQuickSearch,useArtifactHubTasksProvider).enable-devconsole-integrationfixuseTektonHubIntegration→useHubIntegration, returning[currentStatus, isLoaded].enable-devconsole-integrationis unset then it defaults to trueuseArtifactHubTasksProvider.QuickSearchModalBodysofetchArtifactHubTasksis skipped when integration is off.TektonConfig commands
Enable ArtifactHub dev console integration (default when param is absent):
oc patch tektonconfig config --type=merge -p '{"spec":{"hub":{"params":[{"name":"enable-devconsole-integration","value":"true"}]}}}'Disable ArtifactHub dev console integration:
oc patch tektonconfig config --type=merge -p '{"spec":{"hub":{"params":[{"name":"enable-devconsole-integration","value":"false"}]}}}'Verify current value:
After patching, hard refresh the console (
Cmd+Shift+R/Ctrl+Shift+R) so the plugin re-readsTektonConfig.Screen recordings
hub.tekton.devScreen.Recording.2026-06-18.at.12.56.53.mov
enable-devconsole-integration=true, search in Pipeline Builder; confirm ArtifactHub tasks appear, can be installed and updated and ensure requests go toartifacthub.io....part.-.1.mov
part-2.mov
"false", hard refresh, search again; confirm no ArtifactHub API calls and no ArtifactHub tasks in results (both initial catalog load and live search).Screen.Recording.2026-06-18.at.12.39.15.mov