Refresh UpdateSdkManTest fixtures after SDKMAN CSV update#1073
Merged
steve-aom-elliott merged 1 commit intomainfrom Apr 27, 2026
Merged
Refresh UpdateSdkManTest fixtures after SDKMAN CSV update#1073steve-aom-elliott merged 1 commit intomainfrom
steve-aom-elliott merged 1 commit intomainfrom
Conversation
The 2026-04-27 auto-update of sdkman-java.csv removed several patch versions that the test fixtures hard-coded: - 17.0.18-tem → only 17.0.19-tem now ships - 11.0.30-amzn → only 11.0.31-amzn now ships - 23.0.1-open and 23.0.2-amzn → no Java 23 entries remain Update the three failing tests to use versions present in the current CSV, choosing pairs that still demonstrate the same recipe behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Today's auto-update of
sdkman-java.csv(commit 9664adb, "[Auto] SDKMAN! Java candidates as of 2026-04-27T1141") removed several patch versions thatUpdateSdkManTesthad hard-coded, breaking three tests onmain:updateVersionExact17.0.18-tem17.0.19-temupdateDistributionOnly11.0.30-tem→11.0.30-amzn11.0.31-zulu→11.0.31-amznupgradeIfNewVersionIsStillSameVersionBasisAndDifferentDistribution23.0.1-open→23.0.2-amzn21.0.10-jbr→21.0.11-temThe pairs were chosen to keep demonstrating the same recipe behavior (exact-version pin, distribution-only swap, and major-pinned upgrade across distributions) using versions present in the current CSV.
Test plan
./gradlew test --tests UpdateSdkManTest.updateVersionExact --tests UpdateSdkManTest.updateDistributionOnly --tests UpdateSdkManTest.upgradeIfNewVersionIsStillSameVersionBasisAndDifferentDistributionpasses locally