Skip to content

feature: add a new api ngx.shared.DICT.cas#583

Open
doujiang24 wants to merge 2 commits intoopenresty:masterfrom
doujiang24:shdict_cas
Open

feature: add a new api ngx.shared.DICT.cas#583
doujiang24 wants to merge 2 commits intoopenresty:masterfrom
doujiang24:shdict_cas

Conversation

@doujiang24
Copy link
Copy Markdown
Member

Just like the replace method, but only stores the key-value pair into the dictionary ngx.shared.DICT if the old_value argument and old_flags argument does match the value and flags in the dictionary ngx.shared.DICT (or one of them).

@dualface
Copy link
Copy Markdown

dualface commented Jan 1, 2016

+1

@agentzh agentzh force-pushed the master branch 2 times, most recently from e7ac10c to cfd4f90 Compare January 31, 2016 19:04
Comment thread doc/HttpLuaModule.wiki Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add the newly added contexts recently, like balancer_by_lua* and ssl_certificate_by_lua*.

@agentzh
Copy link
Copy Markdown
Member

agentzh commented Feb 1, 2016

Please rebase to the latest git master. Thank you :)

@doujiang24
Copy link
Copy Markdown
Member Author

@agentzh Thanks, I have rebased to the master and fixed the confusing descriptions.

@splitice
Copy link
Copy Markdown

+1

I'll be merging this into my fork (with incr ttl). It would be good if there was a FFI (resty core) PR for this too

@dolik-rce
Copy link
Copy Markdown

I was wondering, is there any reason why this wasn't merged yet? Having ngx.shared.DICT.cas() would be very useful.

@agentzh
Copy link
Copy Markdown
Member

agentzh commented Feb 4, 2019

@dolik-rce Just the lack of time and higher priority items. I think @thibaultcha will take care of this :)

@mergify
Copy link
Copy Markdown

mergify Bot commented Jun 26, 2020

This pull request is now in conflict :(

@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 20, 2023

This pull request is now in conflict :(

@mergify mergify Bot added the conflict label Mar 20, 2023
@mergify mergify Bot removed the conflict label May 10, 2023
@mergify
Copy link
Copy Markdown

mergify Bot commented May 10, 2023

This pull request is now in conflict :(

@mergify mergify Bot added the conflict label May 10, 2023
@mergify mergify Bot removed the conflict label Sep 23, 2023
@mergify
Copy link
Copy Markdown

mergify Bot commented Sep 23, 2023

This pull request is now in conflict :(

@mergify mergify Bot added the conflict label Sep 23, 2023
@ShadowJonathan
Copy link
Copy Markdown

Any progress on this? This is the last missing function to make the shared dict truly atomic

@mergify
Copy link
Copy Markdown

mergify Bot commented Mar 6, 2024

This pull request is now in conflict :(

@mergify mergify Bot removed the conflict label Feb 13, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Feb 13, 2025

This pull request is now in conflict :(

@mergify mergify Bot added the conflict label Feb 13, 2025
@mergify mergify Bot removed the conflict label Jul 9, 2025
@mergify
Copy link
Copy Markdown

mergify Bot commented Jul 9, 2025

This pull request is now in conflict :(

@mergify mergify Bot added the conflict label Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants