Skip to content

Refactor deferred end of group processing for flexibility #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bobjacobsen wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactor deferred end of group processing for flexibility #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
88e1a72
Refactor deferred end of group processing for flexibility
bobjacobsen Jul 6, 2026
a273ef2
complete refactor
bobjacobsen Jul 6, 2026
f0b17f9
CI found javadoc errors
bobjacobsen Jul 6, 2026
028df34
trying to understand @Override error
bobjacobsen Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/org/openlcb/Message.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ public String toString() {

/**
* Get the numerical value of the MTI
* @return The MTI as a standard full value
*/
abstract public int getMTI();
}
16 changes: 14 additions & 2 deletions src/org/openlcb/cdi/swing/CdiPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ public java.awt.Dimension getMaximumSize() {
createHelper.add(lineHelper);

// Calls into JMRI to add the Create Sensor and Create Turnout buttons.
factory.handleGroupPaneEnd(createHelper);
factory.handleManualEnd(createHelper);
sensorHelperPanel = new CollapsiblePanel("Sensor/Turnout creation", createHelper);
sensorHelperPanel.setBackground(getForeground());
sensorHelperPanel.setExpanded(false);
Expand Down Expand Up @@ -3203,6 +3203,19 @@ public void handleGroupPaneStart(JPanel pane) {
return;
}

/**
* Similar to handleGroupPaneEnd, this asserts that the
* processing should happen on the current group
* which has been manually (e.g. not from CDI) created.
*
* @param pane The GUI panel that has been populated with the
* representation of the group. In {@link CdiPanel},
* this is a {@link GroupPane}.
*/
public void handleManualEnd(JPanel pane) {
handleGroupPaneEnd(pane); // default implementation provides same function
}

/**
* Called after a group have been constructedd.
* Paired with {@link handleGroupPaneStart}.
Expand All @@ -3212,7 +3225,6 @@ public void handleGroupPaneStart(JPanel pane) {
* this is a {@link GroupPane}.
*/
public void handleGroupPaneEnd(JPanel pane) {
return;
}

/**
Expand Down
Loading