Security: Add mTLS client certificate support#116
Security: Add mTLS client certificate support#116paolostivanin wants to merge 1 commit intoopencloud-eu:mainfrom
Conversation
|
Thank you for the PR, looks small enough to merge. However: Did you see @michaelstingl 's proposal here: https://github.com/orgs/opencloud-eu/discussions/819#discussioncomment-13102292 |
|
hello! Yes, I saw that discussion but as opencloud-eu/opencloud#819 (reply in thread) pointed out, this is a different use case compared to the IdP mTLS 😃 |
9318e08 to
daf05bc
Compare
|
hello :) is there any more feedback about this PR? Thanks |
|
@paolostivanin I will have a look for 1.3.0 :) |
thanks a lot, much appreciated 😄 |
|
Built and sideloaded on my Samsung Galaxy S22 on Android 16; using CF Zero Trust and tunnel --> caddy --> Opencloud with Authentik OIDC. I'll post any issues I have. |
Allow users to present a client certificate for mutual TLS authentication (e.g. Cloudflare mTLS). Uses Android KeyChain API so users pick from certificates already installed on device.
|
@paolostivanin Thank you, what are the changes from before? |
Just a rebase against latest master, I saw that there was a merge conflict. |
Allow users to present a client certificate for mutual TLS authentication (e.g. Cloudflare mTLS). Uses Android KeyChain API so users pick from certificates already installed on device.
Tested on my device (OnePlus 13R) with Android 16. My setup is: Cloudflare (with mTLS) -> NPM -> homelab
I've installed the
opencloudApp/build/outputs/apk/qa/debug/OpenCloud_1.2.1-qa-debug.apkon my device and with this is version and the certificate selected I can browse my data, with upstream's version sync and browsing fail (as expected).I've been using this debug apk for a few days now and I have not faced any issues.
Please note that I am NOT an Android developer, so please review the changes carefully for any mistake I might have made 😃