Satellite UI API to S3 Presigned URL #321
Open
suvanbanerjee wants to merge 7 commits into
Open
Conversation
| """S3 client.""" | ||
| import boto3 | ||
| from botocore.client import Config | ||
| from botocore.exceptions import ClientError |
Contributor
There was a problem hiding this comment.
You might want to consider using fsspec, can be slightly easier to use that boto3 and botocore. We have tended to use fsspec in some other mircoservices
Contributor
There was a problem hiding this comment.
Cool, fine with this for now but I think boto3 is slightly more resilient in the pre-signed URL stuff. Can always tweak later if needed though!
| @@ -0,0 +1,29 @@ | |||
| """S3 client.""" | |||
| import fsspec | |||
Contributor
There was a problem hiding this comment.
looks good you are using fsspec now
Contributor
peterdudfield
left a comment
peterdudfield
left a comment
There was a problem hiding this comment.
Thanks for using fsspec, I let @braddf review this properly, as I dont know the full ins and outs of this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Add endpoint to get s3 URL of a specific layer and channel
Checklist: