Fix bare dict annotation handling#3433
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3338.
Fixes #3341.
Summary
dictannotations as unparameterized mappings inconstruct_type().dictvalues during request transform instead of indexing missing type args.dicthandling in both model construction and sync/async transform paths.Root Cause
Both code paths assumed dictionary annotations always include key/value type arguments, e.g.
dict[str, T]orDict[str, T]. A baredicthas notyping.get_args()entries, so indexing or unpacking those args raisedIndexError/ValueError.Validation
env HTTP_PROXY= HTTPS_PROXY= ALL_PROXY= NO_PROXY='*' http_proxy= https_proxy= all_proxy= no_proxy='*' uv run --with pytest --with pytest-asyncio --with pytest-xdist --with dirty-equals --with respx --with time-machine --with 'httpx[socks]' pytest tests/test_transform.py tests/test_models.py -q-> 117 passeduv run --with ruff ruff format --check src/openai/_models.py src/openai/_utils/_transform.py tests/test_models.py tests/test_transform.pyuv run --with ruff ruff check src/openai/_models.py src/openai/_utils/_transform.py tests/test_models.py tests/test_transform.pygit diff --check