Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions NIGHTLY_CODEX_FINAL_ATTEMPT_1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
Implemented the focused fix for openai/openai-python#2502.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove nightly attempt report from repository

Drop this generated NIGHTLY_CODEX_FINAL_ATTEMPT_1.md artifact from the commit: it contains CI-local absolute paths and run-specific narrative (including "I did not commit..."), which will go stale immediately and adds maintenance noise unrelated to the library’s source, tests, or user-facing docs.

Useful? React with 👍 / 👎.


Changed:
- [src/openai/types/realtime/realtime_response_status.py](/home/runner/work/oss-nightly-control/oss-nightly-control/target/src/openai/types/realtime/realtime_response_status.py): added optional `Error.message`.
- [src/openai/types/beta/realtime/realtime_response_status.py](/home/runner/work/oss-nightly-control/oss-nightly-control/target/src/openai/types/beta/realtime/realtime_response_status.py): added the same field for beta realtime.
- [tests/test_realtime_response_status.py](/home/runner/work/oss-nightly-control/oss-nightly-control/target/tests/test_realtime_response_status.py): added regression coverage for declared model fields and failed `response.done` payload parsing.
- [NIGHTLY_REPORT.md](/home/runner/work/oss-nightly-control/oss-nightly-control/target/NIGHTLY_REPORT.md): written with summary, tests, and risks.

Verified:
- `uv run python -m pytest tests/test_realtime_response_status.py -q` passed: `4 passed`
- `uv run ruff check ...` passed
- `uv run ruff format --check ...` passed
- `uv run python -m compileall -q ...` passed

I did not commit, push, or open a PR. The issue context used was https://github.com/openai/openai-python/issues/2502.
3 changes: 3 additions & 0 deletions src/openai/types/beta/realtime/realtime_response_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,9 @@ class Error(BaseModel):
code: Optional[str] = None
"""Error code, if any."""

message: Optional[str] = None
"""A human-readable error message."""

type: Optional[str] = None
"""The type of error."""

Expand Down
3 changes: 3 additions & 0 deletions src/openai/types/realtime/realtime_response_status.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ class Error(BaseModel):
code: Optional[str] = None
"""Error code, if any."""

message: Optional[str] = None
"""A human-readable error message."""

type: Optional[str] = None
"""The type of error."""

Expand Down
71 changes: 71 additions & 0 deletions tests/test_realtime_response_status.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
from openai._compat import parse_obj, get_model_fields
from openai.types.realtime.response_done_event import ResponseDoneEvent
from openai.types.beta.realtime.response_done_event import ResponseDoneEvent as BetaResponseDoneEvent
from openai.types.realtime.realtime_response_status import Error as RealtimeResponseStatusError
from openai.types.beta.realtime.realtime_response_status import Error as BetaRealtimeResponseStatusError

ERROR_MESSAGE = "We're currently processing too many requests - please try again later."


def test_realtime_response_status_error_declares_message() -> None:
assert "message" in get_model_fields(RealtimeResponseStatusError)


def test_beta_realtime_response_status_error_declares_message() -> None:
assert "message" in get_model_fields(BetaRealtimeResponseStatusError)


def test_realtime_response_done_failed_error_message() -> None:
event = parse_obj(
ResponseDoneEvent,
{
"type": "response.done",
"event_id": "event_123",
"response": {
"object": "realtime.response",
"id": "resp_123",
"status": "failed",
"status_details": {
"type": "failed",
"error": {
"type": "invalid_request_error",
"code": "inference_rate_limit_exceeded",
"message": ERROR_MESSAGE,
},
},
"output": [],
},
},
)

assert event.response.status_details is not None
assert event.response.status_details.error is not None
assert event.response.status_details.error.message == ERROR_MESSAGE


def test_beta_realtime_response_done_failed_error_message() -> None:
event = parse_obj(
BetaResponseDoneEvent,
{
"type": "response.done",
"event_id": "event_123",
"response": {
"object": "realtime.response",
"id": "resp_123",
"status": "failed",
"status_details": {
"type": "failed",
"error": {
"type": "invalid_request_error",
"code": "inference_rate_limit_exceeded",
"message": ERROR_MESSAGE,
},
},
"output": [],
},
},
)

assert event.response.status_details is not None
assert event.response.status_details.error is not None
assert event.response.status_details.error.message == ERROR_MESSAGE