feat(ambient): relax default prompt, sender UID, debug mode#1221
Conversation
This comment has been minimized.
This comment has been minimized.
a720d85 to
a884cfe
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a884cfe to
5305e65
Compare
This comment has been minimized.
This comment has been minimized.
8d2241c to
e90eceb
Compare
This comment has been minimized.
This comment has been minimized.
e90eceb to
bd48218
Compare
This comment has been minimized.
This comment has been minimized.
bd48218 to
85e88b8
Compare
This comment has been minimized.
This comment has been minimized.
85e88b8 to
ef8a140
Compare
This comment has been minimized.
This comment has been minimized.
ef8a140 to
d185694
Compare
This comment has been minimized.
This comment has been minimized.
d185694 to
5351065
Compare
This comment has been minimized.
This comment has been minimized.
…mode - Relax DEFAULT_AMBIENT_SYSTEM_INSTRUCTION: bias toward engagement, only [NO_REPLY] for purely social chatter - Add @mention rule: bot always mentions the person it's responding to - Add sender_id to AmbientMessage, format transcript as: Name (<@uid>): message - Add debug config: when [ambient] debug = true: - [NO_REPLY] responses are sent to the channel (not suppressed) - A system message is posted on each flush showing batch size and senders - Add tests for new prompt and UID-in-transcript behavior
5351065 to
2edeef9
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
LGTM ✅ SummaryRelaxes ambient mode default prompt, adds sender UID to transcripts for @mentions, and introduces a debug mode for observing ambient behavior. Changes
Review Findings (All Resolved)
VerdictAll findings addressed. No blockers. Ready to merge. |
|
LGTM ✅ — Clean ambient mode enhancement: relaxed default prompt, sender UID in transcript for @mentions, and opt-in debug mode with appropriate safeguards. What This PR DoesAmbient mode bots were too conservative—staying silent unless they had "meaningful help, context, or corrections." This PR relaxes the default prompt to bias toward engagement (reply when there is a question or actionable topic, How It Works
Findings
What's Good (🟢)
Baseline Check
|
What
[NO_REPLY]for purely social chatter.Name (<@UID>): message) so the LLM can produce valid mentions.[ambient] debug = true):[NO_REPLY]responses are sent to channel instead of suppressedConfig
Changes
ambient.rs: UpdatedDEFAULT_AMBIENT_SYSTEM_INSTRUCTION, addedsender_idtoAmbientMessage, UID in transcript format, debug flush notifications, pass-through[NO_REPLY]in debug mode.discord.rs: Passmsg.author.idwhen constructingAmbientMessage.config.rs: Addeddebug: booltoAmbientConfig.Backward compatibility
Default behavior unchanged (
debug = false). The only behavioral change is the relaxed default prompt — bots will reply more often in ambient mode.