Do not add default ports for explicit hosts#687
Open
lin-hongkuan wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop
_parse_hostfrom appending:80or:443when the input already includes an explicithttp://orhttps://scheme without a port.Motivation
When callers configure a custom host such as
https://example.com, the client currently normalizes it tohttps://example.com:443. That changes the visible configured host and can be problematic for reverse proxies or environments that expect the default port to remain implicit.Fixes #222
Changes
:11434for bare hosts.Testing
uv run --with pytest --with pytest-anyio --with pytest-httpserver pytest tests/test_client.py::test_parse_host_default_ports --doctest-modules ollama/_client.py→8 passed in 0.64suv run --with pytest --with pytest-anyio --with pytest-httpserver pytest tests/test_client.py::test_parse_host_default_ports --doctest-modules ollama/_client.py tests/test_client.py→80 passed in 3.29suv run --with ruff ruff check ollama/_client.py tests/test_client.py→All checks passed!git diff --check